Skip to content

Fix ant build after 3796#3827

Merged
kasemir merged 1 commit into
masterfrom
fix_3796
Jun 9, 2026
Merged

Fix ant build after 3796#3827
kasemir merged 1 commit into
masterfrom
fix_3796

Conversation

@kasemir

@kasemir kasemir commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

PR 3796 added a dependency from display-runtime to the databrowser

  • Testing:
    Before this fix, ant build fails with
app-display-runtime:
    [javac] ...OpenDataBrowserActionHandler.java:9: error:
            package org.csstudio.trends.databrowser3 does not exist
    [javac] import org.csstudio.trends.databrowser3.DataBrowserApp;

With this fix, it completes the build process.

PR 3796 added a dependency from display-runtime to the databrowser
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

@kasemir kasemir merged commit abd9a05 into master Jun 9, 2026
5 checks passed
@kasemir kasemir deleted the fix_3796 branch June 9, 2026 12:50
@georgweiss

Copy link
Copy Markdown
Collaborator

For save&restore actions I have put the implementation in that module. We could consider the same for this action, i.e. put in some data browser module.

@kasemir

kasemir commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator Author

display-representation already depended on databrowser because of the DBwidget.
Now display-runtime depends on DB as well.
Not sure how important it is to neaten the dependency graph within the core and app modules. In any case, we can do that at our own pace.
I'm more worried about the ~250 external dependencies in dependencies/phoebus-target/target/lib. Something in there could require an update because of some severe bug, and if that is then incompatible with some other external dependency, you're stuck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants