Add thread & project token usage labels#492
Conversation
Samigos
changed the title
Samigos
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3843032994
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Object.entries(threadsByWorkspace).forEach(([workspaceId, threads]) => { | ||
| const total = threads.reduce( | ||
| (sum, thread) => sum + getDisplayThreadTokenUsageTotal(tokenUsageByThread[thread.id]), | ||
| 0, | ||
| ); |
There was a problem hiding this comment.
getWorkspaceTokenUsageLabel derives each project total from threadsByWorkspace, but that state only contains the first page of threads because listThreadsForWorkspaces truncates to THREAD_LIST_TARGET_COUNT before storing summaries. In any workspace with more than 20 threads, the workspace/worktree token label will systematically undercount usage, so the displayed “project” total can be materially wrong until users manually page in older threads.
Useful? React with 👍 / 👎.
| let walker = WalkBuilder::new(root) | ||
| .hidden(false) | ||
| .follow_links(false) | ||
| .require_git(false) | ||
| .build(); |
There was a problem hiding this comment.
scan_thread_usage builds a filesystem walker over every sessions root and iterates every .jsonl file for each snapshot request, even when only a small threadIds subset is requested. Because sidebar thread-list refreshes trigger these snapshots, usage hydration cost scales with total session history size, which can make routine list/paging operations noticeably slow on long-lived workspaces.
Useful? React with 👍 / 👎.
# Conflicts: # src/features/threads/hooks/useThreadActions.test.tsx # src/features/threads/hooks/useThreadActions.ts # src/features/threads/hooks/useThreadsReducer.test.ts
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@Samigos is it possible to show actual costs in $$$? |
Looking into it right now |
|
Just probably should state somewhere that those are estimations and might differ from the actual bill. Other than that this feature would be super useful. |
… thread-token-usage # Conflicts: # src/features/threads/hooks/useThreadActions.test.tsx # src/features/threads/hooks/useThreadActions.ts
xkonjin
left a comment
xkonjin
left a comment
There was a problem hiding this comment.
Quick review pass:
- Main risk area here is auth/session state and stale credential handling.
- Good to see test coverage move with the code; I’d still make sure it exercises the unhappy path around auth/session state and stale credential handling rather than only the happy path.
- Before merge, I’d smoke-test the behavior touched by codex_monitor_daemon.rs, workspace.rs, lib.rs (+40 more) with malformed input / retry / rollback cases, since that’s where this class of change usually breaks.
|
@xkonjin You mean in case the user switch accounts? |
5 participants
Summary
Validation