fix(results): supersede stale remote sync errors#1338
Merged
Conversation
cdc6a32 to
c7a7276
Compare
Deploying agentv with
|
| Latest commit: |
c7a7276
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95e9e75b.agentv.pages.dev |
| Branch Preview URL: | https://fix-av-xqm-stale-last-error.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
av-fis,av-fis.1,av-fis.2,av-fis.3,av-xqm) from the NTM-only graph into the AgentV branch graph.av-xqmby derivinglast_errorfrom the current results-repo git inspection so stale persisted errors are cleared or superseded when status changes.Beads
av-xqmav-fis,av-fis.1,av-fis.2,av-fis.3/tmp/agentv-beads-backups-20260609T054751ZRed/Green Evidence
bun test packages/core/test/evaluation/results-repo.test.ts -t "supersedes stale sync errors"failed before the implementation with staleResults repo has uncommitted changes and auto_push is disabledwhile current status was conflicted.Verification
bun test packages/core/test/evaluation/results-repo.test.tspassed 12/12.bun run buildpassed afterbun installin the fresh worktree; existing Dashboard large-chunk warning only.bun test apps/cli/test/commands/results/serve.test.tspassed 83/83.bunx biome check packages/core/src/evaluation/results-repo.ts packages/core/test/evaluation/results-repo.test.tspassed.bun run testpassed across core/eval/phoenix/cli/dashboard packages.biome check ..Migration Notes
last_errorsnake_case field; it now reflects the current inspected status instead of stale persisted sync errors.Remaining Follow-ups
av-fis.1: Dashboard stuckSyncing...UI state.av-fis.2: confirm/finish first-class CLI remote status/sync contract if current command surface is incomplete.av-fis.3: interrupted retry/cleanup coverage for git lock/rebase/rejected-push cases.