Skip to content

fix(results): supersede stale remote sync errors#1338

Merged
christso merged 1 commit into
mainfrom
fix/av-xqm-stale-last-error
Jun 9, 2026
Merged

fix(results): supersede stale remote sync errors#1338
christso merged 1 commit into
mainfrom
fix/av-xqm-stale-last-error

Conversation

@christso

@christso christso commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Reconciles the remote-sync follow-up Beads (av-fis, av-fis.1, av-fis.2, av-fis.3, av-xqm) from the NTM-only graph into the AgentV branch graph.
  • Implements av-xqm by deriving last_error from the current results-repo git inspection so stale persisted errors are cleared or superseded when status changes.
  • Adds a regression that reproduces a dirty sync failure followed by a conflicted repo status and asserts the current conflict error replaces the older dirty-sync error.

Beads

  • Implements: av-xqm
  • Parent/reconciled follow-ups: av-fis, av-fis.1, av-fis.2, av-fis.3
  • Backup before reconciliation: /tmp/agentv-beads-backups-20260609T054751Z

Red/Green Evidence

  • Red: bun test packages/core/test/evaluation/results-repo.test.ts -t "supersedes stale sync errors" failed before the implementation with stale Results repo has uncommitted changes and auto_push is disabled while current status was conflicted.
  • Green: the same focused regression passed after the implementation.

Verification

  • bun test packages/core/test/evaluation/results-repo.test.ts passed 12/12.
  • bun run build passed after bun install in the fresh worktree; existing Dashboard large-chunk warning only.
  • bun test apps/cli/test/commands/results/serve.test.ts passed 83/83.
  • bunx biome check packages/core/src/evaluation/results-repo.ts packages/core/test/evaluation/results-repo.test.ts passed.
  • bun run test passed across core/eval/phoenix/cli/dashboard packages.
  • Pre-push hook also passed typecheck and biome check ..

Migration Notes

  • No config or wire-format migration required.
  • API/status JSON still uses the existing last_error snake_case field; it now reflects the current inspected status instead of stale persisted sync errors.

Remaining Follow-ups

  • av-fis.1: Dashboard stuck Syncing... UI state.
  • av-fis.2: confirm/finish first-class CLI remote status/sync contract if current command surface is incomplete.
  • av-fis.3: interrupted retry/cleanup coverage for git lock/rebase/rejected-push cases.

@christso christso force-pushed the fix/av-xqm-stale-last-error branch from cdc6a32 to c7a7276 Compare June 9, 2026 06:23
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 9, 2026

Copy link
Copy Markdown

Deploying agentv with  Cloudflare Pages  Cloudflare Pages

Latest commit: c7a7276
Status: ✅  Deploy successful!
Preview URL: https://95e9e75b.agentv.pages.dev
Branch Preview URL: https://fix-av-xqm-stale-last-error.agentv.pages.dev

View logs

@christso christso merged commit 7794489 into main Jun 9, 2026
8 checks passed
@christso christso deleted the fix/av-xqm-stale-last-error branch June 9, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant