use ValueError if moving_average window size is out of bounds

Author: MikeSullivan7

ratapi/utils/plotting.py

@@ -1132,7 +1132,6 @@ def validate_dens_type(dens_type: str | None, param: str):
             results,
             i,
             smooth=smooth,
-            sigma=sigma,
             estimated_density=estimated_density.get(i),
             axes=ax,
             **hist_settings,
@@ -1247,14 +1246,17 @@ def moving_average(data: np.ndarray, window_size: int = 8) -> list[float]:
                   computing an average over the elements within each window.
 
     """
-    assert 0 <= window_size <= len(data)
+    if not 0 <= window_size <= len(data):
+        raise ValueError(
+            "The moving average window size is out of range. Please change to a positive integer which "
+            "does not exceed the number of histogram bins."
+        )
     moving_averages = []
 
     for i in range(len(data)):
         start_window_ind = floor(float(i - window_size / 2)) if i - window_size / 2 > 0 else 0
         end_window_ind = floor(float(i + window_size / 2)) if i + window_size / 2 < len(data) else len(data)
         window_average = np.sum(data[start_window_ind:end_window_ind]) / (end_window_ind + 0 - start_window_ind)
         moving_averages.append(window_average)
-        i += 1
 
     return moving_averages

tests/test_plotting.py

@@ -548,8 +548,8 @@ def test_moving_average() -> None:
         18.5,
     ]
 
-    with pytest.raises(AssertionError):
+    with pytest.raises(ValueError):
         RATplot.moving_average(data_to_average, window_size=-1)
 
-    with pytest.raises(AssertionError):
+    with pytest.raises(ValueError):
         RATplot.moving_average(data_to_average, window_size=len(data_to_average) + 1)