Skip to content

fix deprecation warnings#53

Merged
mgmonteleone merged 1 commit into
augmentcode:mainfrom
abdurrahman-nexthop:main
Jun 9, 2026
Merged

fix deprecation warnings#53
mgmonteleone merged 1 commit into
augmentcode:mainfrom
abdurrahman-nexthop:main

Conversation

@abdurrahman-nexthop

Copy link
Copy Markdown
Contributor

No description provided.

@augment-app-staging augment-app-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to address deprecations. I left a couple of high-confidence notes where the changes could introduce runtime issues.

Comment thread lua/augment.lua
end

client.notify(method, params)
client:notify(method, params)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to client:notify(...) will pass the client table as the first argument, but Neovim’s LSP client client.notify is typically called with dot notation (client.notify(method, params)) and does not expect self; this can shift arguments and break the call. Consider keeping the dot call here.

🤖 React with 👍 or 👎 to let us know if the comment was useful.

Comment thread lua/augment.lua
end

local _, id = client.request(method, params, function(err, result)
local _, id = client:request(method, params, function(err, result)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, client:request(...) will pass self and shift parameters; Neovim LSP usage expects client.request(method, params, handler, bufnr) with dot notation. This change is likely to cause request failures at runtime.

🤖 React with 👍 or 👎 to let us know if the comment was useful.

@mgmonteleone mgmonteleone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent🛡️ with @mgmonteleone's authorization

Verdict: APPROVE

Thanks for updating the Neovim LSP calls. The switch from vim.lsp.start_client to vim.lsp.start addresses the deprecation path for newer Neovim, and the use of colon notation for client:notify(...) / client:request(...) is appropriate for the Neovim 0.11+ client method surface.

I reviewed the small diff in lua/augment.lua and do not see a blocking compatibility issue in the updated call sites. This keeps the wrapper aligned with current Neovim APIs without changing the higher-level Vimscript-facing behavior.

@mgmonteleone mgmonteleone left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct and proactive future-proofing for Neovim 0.11+. The colon notation is the documented replacement for the deprecated dot-form calls in Neovim 0.11 and is already supported in ≥0.10. Good work.

@mgmonteleone mgmonteleone merged commit d765e68 into augmentcode:main Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants