-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enable automated golden refresh #17458
Copy link
Copy link
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Currently, when we update our gapic-generator templates, we have to manually update the golden services. At the same time, we have an Integration test that will alert us if the goldens we generate differ from what's expected
We should use the logic we already have in that CI test, and add a step where the CI will push changes to our goldens when the templates are modified. This would save manual work, and be easier to communicate to new team members