Replies: 1 comment
-
|
Great initiative! Agree on the above, only a little uncertain about the best interface for adding multiple openings. Going from GROUP to handling them in the standard component would be great. Vector input is great for hardcoded values, but using parameters or variables requires a bit of DECLARE / INITIALIZE code. That is probably okay for the definitions of openings, typically frequency and phase will use parameters/variables and these do not need to be vectors. The other slight issue with vector input is that there size cannot be read, so another variable is needed to convey that. The MultiDiskChopper has a default value of length 2, but perhaps it should be a required parameter. Is there any potential way to improve this aspect? I propose simply calling the new component Chopper, as a disc chopper seems to be by far the most common type of chopper. I intend to start a prototype soon and make a branch that would provide something concrete for this discussion. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Picking up on #2347 my own 0.02€ are:
vectortype input to add multiple openings pr. discNCrystal)exampleinstruments to the new component definitionobsoleteBeta Was this translation helpful? Give feedback.
All reactions