Skip to content

Blog: v22.4.0 release post#6888

Merged
ovflowd merged 1 commit into
nodejs:mainfrom
targos:v22.4.0
Jul 2, 2024
Merged

Blog: v22.4.0 release post#6888
ovflowd merged 1 commit into
nodejs:mainfrom
targos:v22.4.0

Conversation

@targos

@targos targos commented Jul 2, 2024

Copy link
Copy Markdown
Member

@targos targos requested a review from a team as a code owner July 2, 2024 09:08
@vercel

vercel Bot commented Jul 2, 2024 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Jul 2, 2024 9:08am

@targos targos added the github_actions:pull-request Trigger Pull Request Checks label Jul 2, 2024
@github-actions github-actions Bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 2, 2024
@github-actions

github-actions Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Running Lighthouse audit...

@targos targos enabled auto-merge July 2, 2024 09:09
@github-actions

github-actions Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.411s ⏱️

@targos

targos commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

Vercel error:

Running "[[ "$VERCEL_GIT_COMMIT_REF" =~ dependabot* || "$VERCEL_GIT_COMMIT_REF" =~ gh-readonly* ]]"
Error: The specified Root Directory "apps/site" does not exist. Please update your Project Settings. Learn More: https://vercel.com/docs/build-step#root-directory
The specified Root Directory "apps/site" does not exist. Please update your Project Settings.

I have no idea what to do here.

@AugustinMauroy

AugustinMauroy commented Jul 2, 2024

Copy link
Copy Markdown
Member

@ovflowd I thinks you change something on Vercel config to allow monorepo ?

mikeesto
mikeesto approved these changes Jul 2, 2024
View reviewed changes

@mikeesto mikeesto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. With the push to a monorepo CI isn't aligned correctly right now, this should still be fine to merge as we have done for other recent blog posts.

@targos

targos commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

I don't know how to go forward with the two failed checks

@ovflowd ovflowd merged commit c19f996 into nodejs:main Jul 2, 2024
@targos targos deleted the v22.4.0 branch July 3, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikeesto mikeesto mikeesto approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@targos @AugustinMauroy @mikeesto @RafaelGSS @ovflowd