Skip to content

Don't panic on invalid version status#328

Merged
hugovk merged 7 commits into
python:mainfrom
m-aciek:graceful-support-for-invalid-version-status
Feb 26, 2026
Merged

Don't panic on invalid version status#328
hugovk merged 7 commits into
python:mainfrom
m-aciek:graceful-support-for-invalid-version-status

Conversation

@m-aciek

@m-aciek m-aciek commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #327.

Example warning (CI):

2026-02-26 00:54:36,409 WARNING: Saw invalid version status '', expected to be one of EOL, bugfix, end-of-life, feature, in development, pre-release, prerelease, security, security-fixes, stable. Context: {'branch': '', 'pep': 826, 'status': '', 'first_release': '2027-10-06', 'end_of_life': '2032-10', 'release_manager': 'Savannah Ostrowski'}

hugovk
hugovk reviewed Feb 26, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Comment thread tests/test_build_docs_versions.py Outdated
Comment thread tests/test_build_docs_versions.py Outdated
m-aciek and others added 2 commits February 26, 2026 14:15
@m-aciek @hugovk
Apply suggestions from code review
bc74b13 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@m-aciek
Store result of from_json in versions variable
93eaf54
hugovk
hugovk reviewed Feb 26, 2026
View reviewed changes
Comment thread tests/test_build_docs_versions.py Outdated
@m-aciek @hugovk
Update tests/test_build_docs_versions.py
9915f9d 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@hugovk hugovk merged commit 3116451 into python:main Feb 26, 2026
13 checks passed
@hugovk

hugovk commented Feb 26, 2026

Copy link
Copy Markdown
Member

Thanks!

@m-aciek m-aciek deleted the graceful-support-for-invalid-version-status branch February 26, 2026 13:31
@m-aciek

m-aciek commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!

My pleasure :) 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Skip empty branch/status from release-cycle file

2 participants

@m-aciek @hugovk