Add Expo plugin with expo and eas CLI support#563
Conversation
|
Friendly follow up |
|
Kindly following up |
scottisloud
left a comment
There was a problem hiding this comment.
Thanks for your patience on this one — sorry it's taken a while to get back to you.
I've reviewed the Expo plugin and it looks ready to merge. EXPO_TOKEN is the right env var for both expo and eas per Expo's programmatic access docs, the auth gating on both executables is appropriate, and the provisioner/importer tests are in good shape.
Approved — I'll merge once you've rebased onto current main and CI is green. Thanks, @CodeByZach.
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
70bc4ac to
46c4968
Compare
scottisloud
left a comment
There was a problem hiding this comment.
Thanks for bringing the PR up to date! LGTM!
Keep an eye out for this to be included in a future release of the 1Password CLI. Thanks again for your contribution @CodeByZach!
Overview
Adds a shell plugin for Expo, supporting both the
expoandeasCLIs. Authentication is handled via theEXPO_TOKENenvironment variable using access tokens generated from the Expo dashboard.Type of change
Related Issue(s)
How To Test
make expo/buildop plugin init expoexpo whoamiChangelog
Authenticate the Expo and EAS CLIs using 1Password Shell Plugins.