Drop unused path parameter from URLRequest initializer#321
Merged
Conversation
…ta initializers directly
- objectFromCache: a file vanishing between exists() and read (background sweep race) is now a cache miss, not a fatalError; inline the single-use URL.getData() helper that held the crash. - splitBaseURLAndRelativePath: return optional instead of fatalError on unparseable input (breaking: public API now returns an optional tuple).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The custom
URLRequest.init(url:requestType:path:contentType:…)declaredpath _: Stringand discarded it, yet both call sites (requestData,createRequest) threaded apath:argument through it. Removes the dead parameter from the initializer and both call sites.Why
Surfaced during a dead-code sweep. The parameter carried no information into the request — the URL is already built before the init is called. Removing it is behavior-neutral.
Verification
swift buildandswift build --build-testsclean.