Skip to content

DPL Analysis: prevent HistogramRegistry from including ASoA.h#15557

Open
aalkin wants to merge 2 commits into
AliceO2Group:devfrom
aalkin:histogram-registry-exclude-asoa
Open

DPL Analysis: prevent HistogramRegistry from including ASoA.h#15557
aalkin wants to merge 2 commits into
AliceO2Group:devfrom
aalkin:histogram-registry-exclude-asoa

Conversation

@aalkin

@aalkin aalkin commented Jun 25, 2026

Copy link
Copy Markdown
Member
  • Remove ASoA.h and TableBuilder.h includes from HistogramRegistry.h as it is used in various inclusion chains in PWG code
  • Temporarily deprecate "fill with filter" feature, as it not used in O2Physics and requires rework to be efficient

@alibuild

alibuild commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for a75e0bf at 2026-06-26 12:42:

## sw/BUILD/O2Physics-latest/log
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/eaed4e57738464af64bbfd3ca79a9138dadcc1c8/slc9_x86-64/o2checkcode/1.0-local97/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='CMake googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran UUID Python-modules-list date pytorch_cpuinfo ninja FairCMakeModules O2-customization Alice-GRID-Utils defaults-release safe_int json-c MPFR bz2'
+ echo 'FULL_BUILD_REQUIRES=CMake googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran UUID Python-modules-list date pytorch_cpuinfo ninja FairCMakeModules O2-customization Alice-GRID-Utils defaults-release safe_int json-c MPFR bz2'
FULL_BUILD_REQUIRES=CMake googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran UUID Python-modules-list date pytorch_cpuinfo ninja FairCMakeModules O2-customization Alice-GRID-Utils defaults-release safe_int json-c MPFR bz2
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'CMake googlebenchmark double-conversion alibuild-recipe-tools ninja-fortran UUID Python-modules-list date pytorch_cpuinfo ninja FairCMakeModules O2-customization Alice-GRID-Utils defaults-release safe_int json-c MPFR bz2'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
[0 more errors; see full log]

Full log here.

@aalkin aalkin force-pushed the histogram-registry-exclude-asoa branch from a75e0bf to 07c3332 Compare June 26, 2026 09:11
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 07c3332 at 2026-06-26 13:19:

No log files found

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants