Skip to content

[O2B-1588] Implement summary views for overview pages#2156

Open
NarrowsProjects wants to merge 14 commits into
mainfrom
improv/O2B-1588/implement-summary-views-for-overview-pages
Open

[O2B-1588] Implement summary views for overview pages#2156
NarrowsProjects wants to merge 14 commits into
mainfrom
improv/O2B-1588/implement-summary-views-for-overview-pages

Conversation

@NarrowsProjects

@NarrowsProjects NarrowsProjects commented May 13, 2026

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Summary views have been added for listAll endpoints (services and GetAllUseCase files) of:

    • Logs
    • QcFlagTypes
    • LhcFills
    • Environments
    • Runs
    • DataPasses
  • in PaginationModel, the reset function no longer resets _defaultItemsPerPage the reason is that it will always send 1 additional request when overview pages are reset (which is the only context where it is called)

    • Once from the initial fetch
    • Once from the page manually setting _defaultItemsPerPage again (which notifies the page into fetching again)
    • The slight fetch speed improvement from this PR caused some tests to have race conditions on pressElement calls because these would then be called in between the first and second fetch.
  • IMPORTANT:

    • QueryBuilder has been rewritten to use attributes array syntax instead of the previous object syntax.
      • This is required for limiting what top-level fields should be excluded
      • If no explicit columns are provided (computed columns and aliased columns are not included in this), the resulting options object will revert to using object syntax over array syntax.
      • If you want to include only computed or aliased columns without fetching all other columns, you can use the new function called selectOnly

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this May 13, 2026
@NarrowsProjects NarrowsProjects requested a review from graduta as a code owner May 13, 2026 15:36
@NarrowsProjects NarrowsProjects added backend javascript Pull requests that update Javascript code labels May 13, 2026
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch from 5477bce to 365f6a7 Compare May 13, 2026 15:36
@codecov

codecov Bot commented May 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.71429% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.47%. Comparing base (d7cd556) to head (311b1fc).

Files with missing lines Patch % Lines
lib/database/adapters/LogAdapter.js 72.22% 5 Missing ⚠️
lib/database/repositories/Repository.js 75.00% 2 Missing ⚠️
lib/database/utilities/QueryBuilder.js 95.45% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2156      +/-   ##
==========================================
+ Coverage   46.04%   46.47%   +0.42%     
==========================================
  Files        1038     1044       +6     
  Lines       17172    17319     +147     
  Branches     3136     3173      +37     
==========================================
+ Hits         7907     8049     +142     
- Misses       9265     9270       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch 20 times, most recently from 7a14c8d to 8cf3cb6 Compare May 17, 2026 20:55
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch from 8cf3cb6 to 49cfbdc Compare May 17, 2026 21:00
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch 13 times, most recently from 75fd811 to 19c392b Compare June 26, 2026 17:00
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch 2 times, most recently from 154a644 to 6b71f18 Compare June 26, 2026 18:16
@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1588/implement-summary-views-for-overview-pages branch from 9fa0b4d to 311b1fc Compare June 26, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant