Skip to content

[Common] Fix issue 14173#16814

Open
amaringarcia wants to merge 3 commits into
AliceO2Group:masterfrom
amaringarcia:master
Open

[Common] Fix issue 14173#16814
amaringarcia wants to merge 3 commits into
AliceO2Group:masterfrom
amaringarcia:master

Conversation

@amaringarcia

@amaringarcia amaringarcia commented Jun 25, 2026 •
edited by vkucera
Loading

Copy link
Copy Markdown
Contributor

Fixes #14173

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fixing issues/14173 [Common] Fixing issues/14173 Jun 25, 2026
@alibuild alibuild mentioned this pull request Jun 25, 2026
Closed
@vkucera

vkucera commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks a lot @amaringarcia !

@vkucera

vkucera commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

It seems the identicalConditionAfterEarlyExit warnings are still there.

vkucera
vkucera reviewed Jun 25, 2026
View reviewed changes
Comment thread Common/TableProducer/occupancyTableProducer.cxx Outdated
@vkucera vkucera changed the title [Common] Fixing issues/14173 [Common] Fix issue 14173 Jun 25, 2026
@amaringarcia

amaringarcia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Good morning,
now all the warnings/issues are solved (I think).
Can somebody approve and merge this pull request?
Thanks in advance.
Best regards,
Ana

@amaringarcia

amaringarcia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@dsekihat could you approve this pull request? also allow for the merging?

@vkucera

vkucera commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

@amaringarcia Can you please check whether these can be fixed as well?

Common/TableProducer/occupancyTableProducer.cxx:480:142: warning: Identical condition 'meanRobustTableMode==checkTableMode', second condition is always false [identicalConditionAfterEarlyExit]
Common/TableProducer/occupancyTableProducer.cxx:1806:102: warning: Identical condition 'qaMode==checkQAMode', second condition is always false [identicalConditionAfterEarlyExit]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

common

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Potential bugs in occupancyTableProducer.cxx

2 participants

@amaringarcia @vkucera