Use NamedValues for round-trip logger overrides#105
Draft
Copilot wants to merge 13 commits into
Draft
Conversation
Copilot
AI
changed the title
[WIP] Fix named value references in logger credentials override
Normalize logger credential named-value tokens during publish overrides
Jun 2, 2026
Copilot
AI
changed the title
Normalize logger credential named-value tokens during publish overrides
fix: generalize named value token canonicalization across resource payloads
Jun 2, 2026
EMaher
requested changes
Jun 3, 2026
Copilot
AI
changed the title
fix: generalize named value token canonicalization across resource payloads
fix: generalize named value handling across payload canonicalization and transitive extraction
Jun 3, 2026
cba4542 to
ef100db
Compare
Copilot
AI
changed the title
fix: generalize named value handling across payload canonicalization and transitive extraction
Use NamedValues for round-trip logger overrides
Jun 4, 2026
…tion Orchestration Summary: - TestEngineer: Audited named value token coverage, identified Backend resource credential gap - ApimExpert: Generalized named value normalization to all resource types Changes: - Added orchestration logs: 2026-06-02T17-52-56Z-testengineer.md, 2026-06-02T17-52-56Z-apimexpert.md - Added session log: 2026-06-02T17-52-56Z-named-value-normalization.md - Merged inbox decisions into decisions.md (deduplicating 2 related entries) - Deleted inbox files - Updated agent histories to reflect team completion and decision merge Implementation Status: Complete - normalizeLoggerCredentialNamedValueReferences() → normalizeNamedValueReferences() - Applied to all resource types (not just Logger) - Backend credentials now canonicalized - All 910 tests passing Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
587f823 to
a8c502c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The round-trip fixture was still proving logger overrides with hard-coded credential values instead of NamedValue references. This updates the integration scenario so extract/publish exercises NamedValue-backed logger credentials end to end, and phase 4 now overrides the NamedValues rather than the logger payloads.
Round-trip fixture
{{namedValue}}tokensOverride generation
tests/integration/all-resource-types/phases/run-phase4-create-overrides.ps1to populate target-specific values throughnamedValuesresourceIdoverride, but removes direct credential overrides fromloggersExpected extract shape
expected-structure.jsonfor the added NamedValuesExample