Skip to content

Use NamedValues for round-trip logger overrides#105

Draft
Copilot wants to merge 13 commits into
mainfrom
copilot/bug-fix-logger-credentials-override
Draft

Use NamedValues for round-trip logger overrides#105
Copilot wants to merge 13 commits into
mainfrom
copilot/bug-fix-logger-credentials-override

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jun 2, 2026

The round-trip fixture was still proving logger overrides with hard-coded credential values instead of NamedValue references. This updates the integration scenario so extract/publish exercises NamedValue-backed logger credentials end to end, and phase 4 now overrides the NamedValues rather than the logger payloads.

  • Round-trip fixture

    • adds explicit source APIM NamedValues for:
      • Application Insights instrumentation key
      • Event Hub name
      • Event Hub connection string
    • rewires the logger resources to reference those values via {{namedValue}} tokens
  • Override generation

    • updates tests/integration/all-resource-types/phases/run-phase4-create-overrides.ps1 to populate target-specific values through namedValues
    • keeps the App Insights logger resourceId override, but removes direct credential overrides from loggers
  • Expected extract shape

    • extends expected-structure.json for the added NamedValues
    • changes logger expectations from concrete credential values/redacted fields to NamedValue placeholders
  • Example

    namedValues:
      src-nv-appinsights-key:
        value: "<target-ai-key>"
      src-nv-eventhub-name:
        value: "tgt-eh-logs"
      src-nv-eventhub-connection-string:
        value: "<target-eh-connection-string>"
    
    loggers:
      src-logger-appinsights:
        resourceId: "<target-ai-resource-id>"

Copilot AI changed the title [WIP] Fix named value references in logger credentials override Normalize logger credential named-value tokens during publish overrides Jun 2, 2026
Copilot finished work on behalf of EMaher June 2, 2026 05:31
Copilot AI requested a review from EMaher June 2, 2026 05:31
Copilot AI changed the title Normalize logger credential named-value tokens during publish overrides fix: generalize named value token canonicalization across resource payloads Jun 2, 2026
Copilot finished work on behalf of EMaher June 2, 2026 17:56
Copilot finished work on behalf of EMaher June 3, 2026 03:44
Comment thread src/services/resource-publisher.ts
Comment thread src/services/resource-publisher.ts
Comment thread tests/unit/services/resource-publisher.test.ts
Copilot AI changed the title fix: generalize named value token canonicalization across resource payloads fix: generalize named value handling across payload canonicalization and transitive extraction Jun 3, 2026
Copilot finished work on behalf of EMaher June 3, 2026 03:55
Copilot AI requested a review from EMaher June 3, 2026 03:55
@EMaher EMaher force-pushed the copilot/bug-fix-logger-credentials-override branch from cba4542 to ef100db Compare June 4, 2026 17:01
Copilot AI changed the title fix: generalize named value handling across payload canonicalization and transitive extraction Use NamedValues for round-trip logger overrides Jun 4, 2026
Copilot finished work on behalf of EMaher June 4, 2026 17:14
Copilot finished work on behalf of EMaher June 4, 2026 17:31
Copilot AI and others added 7 commits June 5, 2026 21:59
…tion

Orchestration Summary:
- TestEngineer: Audited named value token coverage, identified Backend resource credential gap
- ApimExpert: Generalized named value normalization to all resource types

Changes:
- Added orchestration logs: 2026-06-02T17-52-56Z-testengineer.md, 2026-06-02T17-52-56Z-apimexpert.md
- Added session log: 2026-06-02T17-52-56Z-named-value-normalization.md
- Merged inbox decisions into decisions.md (deduplicating 2 related entries)
- Deleted inbox files
- Updated agent histories to reflect team completion and decision merge

Implementation Status: Complete
- normalizeLoggerCredentialNamedValueReferences() → normalizeNamedValueReferences()
- Applied to all resource types (not just Logger)
- Backend credentials now canonicalized
- All 910 tests passing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@EMaher EMaher force-pushed the copilot/bug-fix-logger-credentials-override branch from 587f823 to a8c502c Compare June 5, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Named value references in logger credentials override not resolved during publish

2 participants