Skip to content

Changed 'verifyNum' to return a BigInt.#628

Merged
Randy808 merged 1 commit into
Blockstream:masterfrom
Randy808:return-bigint-from-verifyNum
Jun 12, 2026
Merged

Changed 'verifyNum' to return a BigInt.#628
Randy808 merged 1 commit into
Blockstream:masterfrom
Randy808:return-bigint-from-verifyNum

Conversation

@Randy808

Copy link
Copy Markdown
Collaborator

To run locally, npm install and use the following snippets:

# Bitcoin
export API_URL=https://blockstream.info/api
export PORT=4999
source flavors/blockstream/config.env
source flavors/bitcoin-mainnet/config.env
npm run dev-server
# Liquid
export API_URL=https://blockstream.info/liquid/api
export PORT=5000
source flavors/blockstream/config.env
source flavors/liquid-mainnet/config.env
npm run dev-server

To test:

  • Download wallycore.js and wallycore.wasm located at https://blockstream.info/liquid/libwally/wallycore.js and https://blockstream.info/liquid/libwally/wallycore.wasm respectively
  • Make a folder called libwally in client/src/lib/ and place the 2 downloaded files in there
  • Add the following lines to dev-server.js after the line router.get('/app.js', browserify(rpath('client/src/run-browser.js'))):
router.get('/libwally/wallycore.js', (req, res) => res.sendFile(rpath('client/src/lib/libwally/wallycore.js')))
router.get('/libwally/wallycore.wasm', (req, res) => res.sendFile(rpath('client/src/lib/libwally/wallycore.wasm')))
  • Start the dev server and navigate to a url that unblinds a value that requires more than 53 bits

@Randy808 Randy808 self-assigned this Jun 10, 2026
EddieHouston
EddieHouston previously approved these changes Jun 11, 2026

@EddieHouston EddieHouston left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@FedOken

FedOken commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator
image http://localhost:5000/tx/fa660f76dc53985af06d0a7a32f499ad6068c90ad4c85fabf7c87b926d6200b6#blinded=1000,1111111111111111111111111111111111111111111111111111111111111111,2222222222222222222222222222222222222222222222222222222222222222,3333333333333333333333333333333333333333333333333333333333333333

@Randy808

Copy link
Copy Markdown
Collaborator Author

@FedOken Did you restart the dev server after making the changes in the description? The server is returning html when requesting wallycore.js which suggests it hasn't

Comment thread client/src/driver/blinding.js Outdated
Comment thread client/src/lib/libwally.js Outdated
Comment thread client/src/lib/libwally.js Outdated
Comment thread client/src/lib/privacy-analysis.js
Comment thread client/src/lib/privacy-analysis.js
Comment thread client/src/lib/privacy-analysis.js Outdated
@Randy808 Randy808 merged commit 9e497dd into Blockstream:master Jun 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants