feat: add PSET decoding and fix genesis arg#48
Open
stringhandler wants to merge 2 commits into
Open
Conversation
- upgraded `simplicity-lang` crate to the latest version
stringhandler
force-pushed
the
feat/pset-run-decode
branch
from
846b722 to
91728b3
Compare
apoelstra
reviewed
Jun 11, 2026
| dependencies = [ | ||
| "memchr", | ||
| ] | ||
| version = 4 |
Contributor
There was a problem hiding this comment.
In cdde169:
FWIW I usually manually change this back to 3 to avoid needlessly breaking old compilers. AFAICT version 4 did not introduce any actual changes.
apoelstra
reviewed
Jun 11, 2026
| [lints.clippy] | ||
| # Exclude lints we don't think are valuable. | ||
| needless_question_mark = "allow" # https://github.com/rust-bitcoin/rust-bitcoin/pull/2134 | ||
| needless_question_mark = "allow" # https://github.com/rust-lang/rust-clippy/pull/2134 |
apoelstra
reviewed
Jun 11, 2026
| http-body-util = { version = "0.1", optional = true } | ||
| tokio = { version = "1.48.0", features = ["full"], optional = true } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
In cdde169:
Prefer not to include whitespace changes (though here it's pretty close to a real change, so doesn't enlarge the diff too much).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The genesis arg didn't actually work previously