gpu(hip) - fix compilation error in gen at-points diagonal assembly#1982
Open
zatkins-dev wants to merge 1 commit into
Open
gpu(hip) - fix compilation error in gen at-points diagonal assembly#1982zatkins-dev wants to merge 1 commit into
zatkins-dev wants to merge 1 commit into
Conversation
jeremylt
reviewed
Jun 8, 2026
jeremylt
left a comment
jeremylt
left a comment
Member
There was a problem hiding this comment.
are both e and elem supposed to be defined at this point?
Collaborator
Author
Not sure. The loop is over elem. |
Member
|
hmm, this should be compared to the operator application kernel to make sure we are not breaking HipStar support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Fixes a minor bug in HIP gen backends which prevented compilation.
We need some way to catch these kind of bugs.
Closes: NA
LLM/GenAI Disclosure:
None