feat(editor): show camera zoom curves on timeline#1894
Open
ivan17lai wants to merge 30 commits into
Open
Conversation
added 27 commits
June 7, 2026 02:10
feat(ui): change zoom curve track icon to Spline
…e to prevent overlap
Member
|
hey @greptileai please review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces "Zoom Curves" visualization on the timeline, replacing the static color blocks. It provides users with an intuitive, visual representation of the camera's physical zoom dynamics.
Key Features
1.0xto4.5x) from the rendering backend.Greptile Summary
This PR adds a
ZoomCurveTrackcomponent that renders SVG Bézier curves on a collapsible timeline sub-row, visually representing camera zoom dynamics from the rendering backend. A newshowZoomCurvesboolean in editor state controls the row's visibility, toggled via a hover overlay on the zoom track's icon.ZoomCurveTrackuses a<For>loop to draw gray baseline and blue ramp SVGs per segment, withoverflow-visibleto extend transition curves across segment boundaries and into adjacent gaps.TrackIcon/TrackRowgainsubordinate,onClick, andiconOverlayprops to support the tree-connected sub-row header and the collapse/expand toggle button.SegmentRootreceives anoverflowVisibleprop to conditionally removeoverflow-hidden, intended for an in-segment inline curve that is computed (dsignal) but whose<svg>rendering was not added to the returned JSX in this PR.Confidence Score: 5/5
Safe to merge — the new ZoomCurveTrack renders correctly and all changes are additive; the unused path computation in ZoomTrack is dead code that does not affect runtime behaviour
All changes are additive UI features behind a new state flag. ZoomCurveTrack curve math and SVG rendering are self-contained and do not touch any data-mutation paths. The dead
dsignal in ZoomTrack is never executed at runtime. No regressions to existing zoom segment drag, resize, or playback logic were introduced.ZoomTrack.tsx contains dead path-computation code that should be resolved before further work builds on the in-segment curve machinery
Important Files Changed
daccessor and all its helper signals are never referenced in the returned JSXPrompt To Fix All With AI
Reviews (2): Last reviewed commit: "chore(ui): remove dead inline curve code..." | Re-trigger Greptile