Skip to content

Mint PMP baselines#756

Open
lewisjared wants to merge 3 commits into
mainfrom
feat/pmp-baselines
Open

Mint PMP baselines#756
lewisjared wants to merge 3 commits into
mainfrom
feat/pmp-baselines

Conversation

@lewisjared

@lewisjared lewisjared commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Mints all of the PMP baselines.

There was one remaining failure (cmip6-pr) that I'll address later.

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

Summary by CodeRabbit

  • Tests
    • Added new catalog/manifest/regression fixtures (annual-cycle, ENSO, and extratropical variability) across CMIP6 and CMIP7, including diagnostic/output/series baselines and standardised empty series placeholders.
  • Bug Fixes / Improvements
    • Improved committed regression bundles to be more portable by sanitising provenance (stable placeholders for user/date) and recording paths relative to the execution output directory.
  • Internal/Build Support
    • Updated the CLI test-case staging flow to consistently apply software-root placeholder handling during mint/replay/build.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f5960f4-e105-495e-84f5-3d5c5d9f8727

📥 Commits

Reviewing files that changed from the base of the PR and between 0f56e50 and 007f94a.

📒 Files selected for processing (29)
  • changelog/756.fix.md
  • changelog/756.improvement.md
  • packages/climate-ref-core/src/climate_ref_core/output_files.py
  • packages/climate-ref-core/src/climate_ref_core/regression/capture.py
  • packages/climate-ref-core/tests/unit/regression/test_capture.py
  • packages/climate-ref-core/tests/unit/test_output_files.py
  • packages/climate-ref-pmp/src/climate_ref_pmp/diagnostics/annual_cycle.py
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/manifest.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/manifest.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/unit/test_annual_cycle.py
  • packages/climate-ref/src/climate_ref/cli/test_cases/_stages.py
  • packages/climate-ref/src/climate_ref/cli/test_cases/baselines.py
  • packages/climate-ref/src/climate_ref/cli/test_cases/run.py
✅ Files skipped from review due to trivial changes (17)
  • changelog/756.fix.md
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/manifest.json
  • changelog/756.improvement.md
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/output.json
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/diagnostic.json

📝 Walkthrough

Walkthrough

Adds climate test-data fixtures and updates capture and CLI staging so regression bundles can redact provenance and substitute a shared software-root placeholder.

Changes

Climate diagnostic test-data fixtures

Layer / File(s) Summary
Annual-cycle fixtures
packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/*, packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/*
catalog.yaml, manifest.json, diagnostic.json, output.json, and series.json fixtures are added for the annual-cycle CMIP6-ts and CMIP7-ts test cases.
ENSO processing fixtures
packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/*, packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/*
catalog.yaml, manifest.json, diagnostic.json, output.json, and series.json fixtures are added for the ENSO processing CMIP6 and CMIP7 test cases.
ENSO teleconnection fixtures
packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/*, packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/*
catalog.yaml, manifest.json, diagnostic.json, output.json, and series.json fixtures are added for the ENSO teleconnection CMIP6 and CMIP7 test cases.
Extratropical modes CMIP6 fixtures
packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-*/cmip6/*
Catalog, manifest, diagnostic, output, and series fixtures are added for the NAM, NAO, NPGO, NPO, PDO, PNA, and SAM CMIP6 test cases.
Extratropical modes CMIP7 fixtures
packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-*/cmip7/*
Catalog, manifest, diagnostic, output, and series fixtures are added for the NAM, NAO, NPGO, NPO, PDO, PNA, and SAM CMIP7 test cases.

Portable regression capture

Layer / File(s) Summary
Placeholder support
packages/climate-ref-core/src/climate_ref_core/output_files.py
A shared-software-root placeholder constant and placeholder pair handling are added to path sanitisation and restoration.
Capture redaction
packages/climate-ref-core/src/climate_ref_core/regression/capture.py, packages/climate-ref-core/tests/unit/regression/test_capture.py
Committed bundle capture now redacts provenance fields and forwards the shared-software root through capture paths, with tests covering redaction and digest stability.
CLI software-root wiring
packages/climate-ref/src/climate_ref/cli/test_cases/_stages.py, packages/climate-ref/src/climate_ref/cli/test_cases/baselines.py, packages/climate-ref/src/climate_ref/cli/test_cases/run.py
Test-case stage helpers and CLI entry points pass config.paths.software into materialise, rebuild, and build calls.
Annual-cycle relative paths
packages/climate-ref-pmp/src/climate_ref_pmp/diagnostics/annual_cycle.py, packages/climate-ref-pmp/tests/unit/test_annual_cycle.py
Annual-cycle execution results now use relative output paths, and the unit test checks the recorded PNG and NetCDF paths.
Output file sanitisation tests
packages/climate-ref-core/tests/unit/test_output_files.py
Tests cover round-tripping the shared-software-root placeholder and the opt-in behaviour when it is not supplied.

Possibly related PRs

  • Climate-REF/climate-ref#748: The staged CLI and bundle-building changes here extend the same test-case materialisation and replay flow introduced in that PR.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main change: minting PMP baselines.
Description check ✅ Passed The description includes the required sections and a clear summary, with only the checklist left unconfirmed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pmp-baselines

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.23.0)
packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/manifest.json

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

[00.39][ERROR]: unable to find a config; path .coderabbit-opengrep-fallback.yml does not exist

packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/manifest.json

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

[00.49][ERROR]: unable to find a config; path .coderabbit-opengrep-fallback.yml does not exist

packages/climate-ref/src/climate_ref/cli/test_cases/_stages.py

┌──────────────┐
│ Opengrep CLI │
└──────────────┘

�[32m✔�[39m �[1mOpengrep OSS�[0m
�[32m✔�[39m Basic security coverage for first-party code vulnerabilities.

[00.17][ERROR]: unable to find a config; path .coderabbit-opengrep-fallback.yml does not exist

  • 5 others
🔧 markdownlint-cli2 (0.22.1)
changelog/756.fix.md

markdownlint-cli2 v0.22.1 (markdownlint v0.40.0)
Error: Unable to use configuration file '/coderabbit-0.markdownlint-cli2.jsonc'; ENOENT: no such file or directory, open '/coderabbit-0.markdownlint-cli2.jsonc'
at throwForConfigurationFile (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:48:9)
at readOptionsOrConfig (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:169:5)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:927:21)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:14:22 {
[cause]: Error: ENOENT: no such file or directory, open '/coderabbit-0.markdownlint-cli2.jsonc'
at async open (node:internal/fs/promises:640:25)
at async Object.readFile (node:internal/fs/promises:1287:14)
at async readOptionsOrConfig (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:141:17)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:927:21)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:14:22 {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/coderabbit-0.markdownlint-cli2.jsonc'
}
}

changelog/756.improvement.md

markdownlint-cli2 v0.22.1 (markdownlint v0.40.0)
Error: Unable to use configuration file '/coderabbit-0.markdownlint-cli2.jsonc'; ENOENT: no such file or directory, open '/coderabbit-0.markdownlint-cli2.jsonc'
at throwForConfigurationFile (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:48:9)
at readOptionsOrConfig (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:169:5)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:927:21)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:14:22 {
[cause]: Error: ENOENT: no such file or directory, open '/coderabbit-0.markdownlint-cli2.jsonc'
at async open (node:internal/fs/promises:640:25)
at async Object.readFile (node:internal/fs/promises:1287:14)
at async readOptionsOrConfig (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:141:17)
at async main (file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2.mjs:927:21)
at async file:///usr/local/lib/node_modules/markdownlint-cli2/markdownlint-cli2-bin.mjs:14:22 {
errno: -2,
code: 'ENOENT',
syscall: 'open',
path: '/coderabbit-0.markdownlint-cli2.jsonc'
}
}


Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 16

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/manifest.json (1)

84-89: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Deduplicate the repeated NPGO EOF2 entry.

This repeats the NPGO_ts_EOF2_monthly_cmip6_ACCESS-ESM1-5_historical_r1i1p1f1_mo_atm_1900-2005.png key already defined above, but with a different hash. JSON parsers will keep only the last copy, so one artefact is silently dropped from the manifest.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0bd8c695-5333-4b2c-b27d-19dd7863ac8d

📥 Commits

Reviewing files that changed from the base of the PR and between 7459cec and 0f56e50.

📒 Files selected for processing (100)
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/manifest.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip6-ts/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/manifest.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/annual-cycle/cmip7-ts/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_proc/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/enso_tel/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nam/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-nao/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npgo/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-npo/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pdo/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-pna/cmip7/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip6/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip6/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip6/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip6/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip6/regression/series.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip7/catalog.yaml
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip7/manifest.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip7/regression/diagnostic.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip7/regression/output.json
  • packages/climate-ref-pmp/tests/test-data/extratropical-modes-of-variability-sam/cmip7/regression/series.json

@lewisjared

Copy link
Copy Markdown
Contributor Author

Re: the out-of-diff note on extratropical-modes-of-variability-npgo/cmip6/manifest.json (duplicate NPGO_ts_EOF2_..._1900-2005.png key) — false positive. I parsed every *.json fixture in this PR with a duplicate-key detector (json.load with an object_pairs_hook) and found zero duplicate keys across all 100 files. In that manifest the ..._1900-2005.png key appears exactly once (line 29), and the cited range (84-89) is past end-of-file — the file is only 84 lines.

…on and <SOFTWARE_ROOT_DIR>

Redact userId/date to <USER>/<DATE> and rewrite shared-software-root paths to <SOFTWARE_ROOT_DIR> alongside the existing <OUTPUT_DIR>/<TEST_DATA_DIR> placeholders, so committed baselines stay portable across machines and reproducible between minting and replay. Re-mint the PMP baselines accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant