Manchester | 26-ITP-May | Yee Man Tsang | Sprint 1 | Coursework by lintsang · Pull Request #1335 · CodeYourFuture/Module-Structuring-and-Testing-Data

lintsang · 2026-06-13T23:01:46Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Follow the instruction of Sprint 1 Coursework and work on the exercises in 4 folders

… is as expected

LonMcGregor

Can you update with the rest of the mandatory sprint 1 exercises please?

lintsang · 2026-06-22T12:48:48Z

Thanks a lot for your reminder. I mistakenly missed the other folders of assignments. Now it is finished.

lintsang · 2026-06-22T12:50:09Z

Can you update with the rest of the mandatory sprint 1 exercises please?

It's finished. Please check.

LonMcGregor

Good work, good explanations. Some tasks need another attempt, see my comments.

LonMcGregor · 2026-06-23T10:03:04Z

+
+//TypeError: Assignment to constant variable.
+//This error is caused by the wrong reassignment of variable 'age'. It is a constant that cannot be reassigned.
+//So the error prompted when the second line code try to reassign the variable value.


How would you change "const" to fix it?

LonMcGregor · 2026-06-23T10:03:57Z

 // Read the code and then answer the questions below

 // a) How many function calls are there in this file? Write down all the lines where a function call is made
+// There is 3 function calls in line 4, 5 and 10. Number() and console.log() both are the function.


These are function calls, good that you found them. Are there any more to find? How many in total?

LonMcGregor · 2026-06-23T10:04:30Z

+// Line 4 is calculating the quotient of the calculation (8784-remainder) divided by 60 to find the movie length in minute. That will be later used to find the display minute in the Hour:Minute:Second format.

 // e) What do you think the variable result represents? Can you think of a better name for this variable?
+// I think the original movie length is in second and this code is to calculate the display of movie length in the Hour:Minute:Second format like what what we see in a normal movie information.


Good explanation, what name could we give to the variable to represent this?

github-actions · 2026-06-23T17:27:29Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

lintsang · 2026-06-23T17:28:03Z

Thanks again for the feedback. I have recorrect all of it.

github-actions · 2026-06-24T06:07:11Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-1/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

LonMcGregor · 2026-06-24T09:54:42Z

Good answers for this, this task is complete. However, I see you've got a message from the bot indicating some incorrect files were changed. Do you know how to resolve that?

lintsang · 2026-06-24T12:46:58Z

Good answers for this, this task is complete. However, I see you've got a message from the bot indicating some incorrect files were changed. Do you know how to resolve that?

Sorry I mistakenly changed the Sprint 2 files. I tried to fix this but cannot find any resources from google can solve it. Reverting a commit cannot be found on my pull request. Can you give me some clue what I can do?

The only solution I can think of is to close this pull request, redo all the steps in exercise and make a new pull request. However, I worried it wastes your time to review my answer all over again.

LonMcGregor · 2026-06-24T15:15:53Z

@lintsang We have a brand new guide to help with this situation: https://curriculum.codeyourfuture.io/guides/reviewing/fixing/

Let me know if that makes sense or if extra guidance is needed

lintsang added 8 commits June 12, 2026 07:19

adding answer to exercise 1

13ca8bc

try method use to take first letter

5082936

add the other two initials to the string

851b51c

extract dir path from the filepath and print it in 3paths.js

ad44093

extract the extension type of the filepath and print it

8937892

remove unnecessary comment line

8948db2

Declare a variable to store the random number and check if the output…

ff9535b

… is as expected

Add comment to explain the break down what num represents

b270139

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 13, 2026

LonMcGregor reviewed Jun 19, 2026

View reviewed changes

LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 19, 2026

lintsang added 3 commits June 20, 2026 08:26

finish exercises in 2-mandatory-errors folder

7131c8e

Finished the exercises in 3-mandatory-interpret folder

6f1e671

Finished all exercises in 4-stretch-explore folder

38c371d

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 22, 2026

LonMcGregor reviewed Jun 23, 2026

View reviewed changes

LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 23, 2026

lintsang added 3 commits June 23, 2026 18:09

recorrect 2-mandatory-errors/1.js

7e23fc3

recorrect 3-mandatory-interpret/1-percentage-change.js

910726e

recorrect 3-mandatory-interpret/2-time-format.js

f20321b

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 23, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 23, 2026

Make sure only Sprint 1 files is touched

5343b19

lintsang added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 24, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 24, 2026

Uh oh!

Conversation

lintsang commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

lintsang commented Jun 22, 2026

Uh oh!

lintsang commented Jun 22, 2026

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 23, 2026

Uh oh!

lintsang commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

LonMcGregor commented Jun 24, 2026

Uh oh!

lintsang commented Jun 24, 2026

Uh oh!

LonMcGregor commented Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lintsang commented Jun 13, 2026 •

edited

Loading