Cape Town | 26-ITP-May | Liyema Mfengwana | Sprint 1 | Coursework Exercises#1340
Open
LiyemaMfengwana wants to merge 17 commits into
Open
Cape Town | 26-ITP-May | Liyema Mfengwana | Sprint 1 | Coursework Exercises#1340LiyemaMfengwana wants to merge 17 commits into
LiyemaMfengwana wants to merge 17 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
LiyemaMfengwana
changed the title
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
changed the title
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
LiyemaMfengwana
changed the title
LiyemaMfengwana
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
LiyemaMfengwana
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
changed the title
LiyemaMfengwana
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
changed the title
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
LiyemaMfengwana
added
the
Needs Review
LonMcGregor
reviewed
Jun 19, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, some changes needed, see my comments.
Comment on lines
+1
to
+8
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| let initials = ``; | ||
| let initials = `firstName[0]+middleName[0]+lastName[0]`; |
There was a problem hiding this comment.
try running this, maybe with a console.log - what do you get as output?
There was a problem hiding this comment.
Did you actually run this code yourself? When I run it I do not get the correct output. What output do you get?
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const ext = lastDotIndex === -1 ? "" : filePath.slice(lastDotIndex); |
There was a problem hiding this comment.
Try running this code, what output do you get?
There was a problem hiding this comment.
When I run this code I get an error. What output do you get?
Author
There was a problem hiding this comment.
i fixed it now, when i run i get pdf
LonMcGregor
added
Reviewed
LiyemaMfengwana
added
the
Needs Review
LonMcGregor
reviewed
Jun 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, thanks for updating. There are still 2 of my original comments you need to have another look at.
Comment on lines
+1
to
+8
| // This should produce the string "CKJ", but you must not write the characters C, K, or J in the code of your solution. | ||
|
|
||
| let initials = ``; | ||
| let initials = `firstName[0]+middleName[0]+lastName[0]`; |
There was a problem hiding this comment.
Did you actually run this code yourself? When I run it I do not get the correct output. What output do you get?
| const dir = ; | ||
| const ext = ; | ||
| const dir = filePath.slice(0, lastSlashIndex); | ||
| const ext = lastDotIndex === -1 ? "" : filePath.slice(lastDotIndex); |
There was a problem hiding this comment.
When I run this code I get an error. What output do you get?
LonMcGregor
removed
the
Needs Review
LiyemaMfengwana
added
the
Needs Review
LonMcGregor
reviewed
Jun 23, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, it was just a couple of bits missing. The tasks are complete now. Well done
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed solutions to sprint 1 coursework.