London | 26-ITP-May | Vito Moratti | Sprint 1 | Coursework#1344
Open
vmoratti wants to merge 18 commits into
Open
London | 26-ITP-May | Vito Moratti | Sprint 1 | Coursework#1344vmoratti wants to merge 18 commits into
vmoratti wants to merge 18 commits into
Conversation
vmoratti
added
Needs Review
LonMcGregor
reviewed
Jun 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task, lots of good explanations. There's a few task where I left comments for you to review
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
|
|
||
| // Answer to a): There are 3 function calls in this file. |
There was a problem hiding this comment.
Where are these 3? Are there any more?
Author
There was a problem hiding this comment.
Sorry, there are 4 function calls. They are on the lines 4, 5, 6 and 7.
There was a problem hiding this comment.
What about when you print the output? Does that use a function?
Author
There was a problem hiding this comment.
and additionally, there is a function call on line 9, which is the console.log(). So 5 function calls in total.
LonMcGregor
added
Reviewed
Renamed variables to start with a letter to avoid SyntaxError.
Updated the number of function calls and provided specific line numbers in comments.
Clarified explanations for alert and prompt functions in Chrome console.
vmoratti
added
the
Needs Review
|
Good work, almost there. Just my comment in Sprint-1/3-mandatory-interpret/1-percentage-change.js to review |
LonMcGregor
removed
the
Needs Review
Added comments to document function calls and error identification.
vmoratti
added
the
Needs Review
|
Great, this task is complete now |
LonMcGregor
removed
Needs Review
LonMcGregor
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed exercises, answered questions.
Questions
It was unclear to me in 4-stretch-explore/chrome.md
Where it says "invoke the function
alertwith an input string of `"Hello world!" "Is it expected from me to use "input()" function, or am i supposed to print "Hello World" to the screen?
Please clarify.
The same goes for the next "prompt" function.
Please clarify the requirements as they are unclear to me.