London | May - 26 | Liridona Shehu | Sprint 1 | Coursework#1345
Open
shehu-dona wants to merge 15 commits into
Open
London | May - 26 | Liridona Shehu | Sprint 1 | Coursework#1345shehu-dona wants to merge 15 commits into
shehu-dona wants to merge 15 commits into
Conversation
…n. Explain expression
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
shehu-dona
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
shehu-dona
changed the title
shehu-dona
added
📅 Sprint 1
LonMcGregor
reviewed
Jun 22, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on this task, lots of good explanations. There's some tasks where I left comments for you to review
| // Read the code and then answer the questions below | ||
|
|
||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | ||
| // There are 4 function calls in this file. |
There was a problem hiding this comment.
Good work finding these 4, are there any others?
|
|
||
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
| // The variable result represent the duration of thr movie in hours,minutes and seconds. | ||
| // A better name fot this variable is movieDuration |
There was a problem hiding this comment.
Is it clear enough what the difference is between a "length" and a "duration"?
LonMcGregor
added
Reviewed
shehu-dona
added
Needs Review
Author
|
Hello LonMcGregor, I read your comments and updated the code. |
LonMcGregor
reviewed
Jun 23, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work and good explanation, this task is done now
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
A PR with js exercises.