Glasgow| May-26-ITP | Yat Long Chan | Sprint 2 | Coursework#1361
Open
Motorcycle-lab wants to merge 8 commits into
Open
Glasgow| May-26-ITP | Yat Long Chan | Sprint 2 | Coursework#1361Motorcycle-lab wants to merge 8 commits into
Motorcycle-lab wants to merge 8 commits into
Conversation
added 7 commits
June 15, 2026 13:30
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
5 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
changed the title
This comment has been minimized.
This comment has been minimized.
Motorcycle-lab
force-pushed
the
acoursework/sprint-2
branch
from
13c32ed to
430f087
Compare
Motorcycle-lab
added
📅 Sprint 2
LonMcGregor
reviewed
Jun 23, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this tasks, I have some suggestions and comments in the tasks for you to resolve
For your question
I would suggest to run code, and run it often as you are writing, so you can spot if there are problems.
We don't expect you to remember every single function, the best way is to do lots of tasks, as well as katas, as you read. Writing code as you go is a good way of learning how different functions work.
I also suggest making your comments actual //coments, this way your editor will highlight valid and invalid js more easily
| and return the expression. | ||
|
|
||
| / function multiply(a, b) { | ||
| return (a * b); |
There was a problem hiding this comment.
Do you need to use the brackets here?
|
|
||
| function sum(a, b) { | ||
| return; | ||
| a + b; |
There was a problem hiding this comment.
When you run this code, does it work correctly?
|
|
||
| let newheight = height / 100; | ||
| let num = weight / (newheight ** 2); | ||
| let idea = num.toFixed(1); |
There was a problem hiding this comment.
Is "idea" a good variable name here?
|
|
||
| // Implement a function that: | ||
| function convertToUpperCase(text) { | ||
| const result = text.toUpperCase(); |
There was a problem hiding this comment.
it is upper cased now, how can you make it "snake case"?
| return `${time} am`; | ||
| } | ||
|
|
||
| else if(hours=== 0o0){ |
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have finished the sprint 2 of coursework required to submit in the pull request.
Questions
How do I remember longer function as a beginner ? Should I decompose the sentence structure ? What approaches do you recommend me to understand the fundamental of the function ?