Skip to content

London | 26-ITP-May | Damilola Odumosu | Sprint 1 | Coursework#1364

Open
d-odumosu wants to merge 12 commits into
CodeYourFuture:mainfrom
d-odumosu:coursework/sprint-1
Open

London | 26-ITP-May | Damilola Odumosu | Sprint 1 | Coursework#1364
d-odumosu wants to merge 12 commits into
CodeYourFuture:mainfrom
d-odumosu:coursework/sprint-1

Conversation

@d-odumosu

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

I have completed the coursework requirements

@d-odumosu d-odumosu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 19, 2026
Comment on lines +8 to +9
//line 3: we are re-assigning count using the assignment operator (=). The " = " is used in JavaScript to assing a value
// to a variable and in this case we are re-assinging count to equal count + 1. No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operation like count = count + 1 is very common in programming, and there is a programming term describing such operation.

Could you find out what one-word programming term describes the operation on line 3?

Comment on lines +21 to +24
const dir = filePath.slice(1 , 44);
console.log(dir)
const ext = filePath.slice(lastSlashIndex + 5 );
console.log(ext)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explore an approach that could work for any valid file path? For examples,
/tmp/interpret/file.json and /Users/mitch/cyf/Module-JS1/mycode.js.

Comment on lines +1 to +2
const _12HourClockTime = "8:53pm";
const $24hourClockTime = "20:53";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifiers that begin with _ or $ are valid variable, function, class, and property names. However, they are usually used by convention to signal special meaning.

Could you explore names that start with alphabets instead? Feel free to ask AI for suggestion.

// line 12 console,log()

// b) Run the code and identify the line where the error is coming from - why is this error occurring? How can you fix this problem?
//A syntaxError is occurring on line 5, we are missing a "," and a closing ")"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can more precisely describe "A comma is missing between "," and "" in the function call" as:
A comma is missing between the ___________s.

What is the programming term that belongs in the blank?

Note: The original code does not have a missing closing ")".

Comment on lines -24 to +31

//runTime

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runTime reads like "runtime", which has a different meaning in IT. Could you suggest a different (and more descriptive) name?

@cjyuan

cjyuan commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Regarding your PR description, could you update the checkboxes to make them look like

  • My changes meet the requirements of the task

instead of like

  • [ x ] My changes meet the requirements of the task

Relevant resource: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/about-tasklists

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants