Glasgow | 26-ITP-May | Sandani Kannangara | Sprint 2 |Coursework

[SandzSoft]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Fixed errors in existing code
• Completed debugging exercises
• Implemented new functions
• Analysed and interpreted code behaviour
• Added and ran test cases to verify solutions

[cjyuan]

Code looks good. I just have a few suggestions.

[cjyuan]

Note: Deleting the global num is optional. Within the function block, num is resolved to the parameter num.
If you are interested in the topic, you can looking up these two concepts, identifier scope and
identifier resolution, in the context of JavaScript programming. ChatGPT can give a good explanation.

[cjyuan]

Why not use mins?

Code is correct. If time permits, you should try to refactor the code (in the whole function) to keep it cleaner.
It's a good practice.

---

Note: The usual practice for an if statement with a single statement in its body is:

if (condition) statement;

or

if (condition) {
    statement;    // Use braces when placing the statement on a separate line.
}

[cjyuan]

The validation bot is rejecting this PR because package.json in the top-level folder was modified. You need to revert the change made to that file to please the validation bot.

Reverting Changes

One way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567.
The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

Ignore tracked file locally

In future PR, to ignore a tracked file such as package.json locally, use:

git update-index --skip-worktree path/to/file

And if you ever need undo the operation in order to track it again, use:

git update-index --no-skip-worktree path/to/file

This is commonly used for local configuration files that differ per developer.

[SandzSoft]

The validation bot is rejecting this PR because package.json in the top-level folder was modified. You need to revert the change made to that file to please the validation bot.

Reverting Changes

One way to revert changes to a file is via the git restore command.

First, locate a commit before the file was modified. It could be the first commit you made, assuming the branch started in a clean state.

Next, record the first 7 characters of the commit SHA.

Suppose the file is path/to/file, and you want to restore the file to its state before the commit with SHA 1234567. The command is:

git restore --source=1234567^ path/to/file

After the file is restored, make a commit and push the changes to GitHub.

Ignore tracked file locally

In future PR, to ignore a tracked file such as package.json locally, use:

git update-index --skip-worktree path/to/file

And if you ever need undo the operation in order to track it again, use:

git update-index --no-skip-worktree path/to/file

This is commonly used for local configuration files that differ per developer.

Thank you for guiding me through GitHub. I’m still new to it, and your explanations have really helped me understand how fix it.

[cjyuan]

Changes look good.

Not everyone can use git on command line correctly. Well done!