Modified integtests to make use of new utility functions for setting trigger config params#491
Open
bieryAtFnal wants to merge 3 commits into
Open
Modified integtests to make use of new utility functions for setting trigger config params#491bieryAtFnal wants to merge 3 commits into
bieryAtFnal wants to merge 3 commits into
Conversation
added 3 commits
May 29, 2026 09:43
…adout window parameters and start making use of common functions to set those params.
3 tasks
MRiganSUSX
reviewed
Jun 26, 2026
MRiganSUSX
left a comment
MRiganSUSX
left a comment
Contributor
There was a problem hiding this comment.
Just one comment here.
| ) | ||
| utility_functions.set_RTCM_trigger_params(oversize_conf, trigger_rate=trigger_rate, | ||
| readout_window_backshift_ticks=0, | ||
| readout_window_before_ticks=2.5*readout_window_time_before, |
Contributor
There was a problem hiding this comment.
readout_window_time_before is hinted to be int (as it should) in https://github.com/DUNE-DAQ/integrationtest/blob/24fce0f387d7609946277b77ee39612213cc65f1/src/integrationtest/utility_functions.py#L102 but used here with float multiplication (2.5).
While this won't cause any problems at runtime, it can break some python type checkers (as int is compatible with float but not the other way around).
I'd suggest casting to int here as:
int(2.5*readout_window_time_before),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes make use of the changes made in the
integrationtestrepo to provide utility functions that set various trigger parameters for integration tests (DUNE-DAQ/integrationtest#161).There are instructions for testing these changes in DUNE-DAQ/integrationtest#161, and these changes need to be tested and merged together the with changes in the
integrationtestrepo.Type of change
Testing checklist
dunedaq_integtest_bundle.sh)