Bsm trigger dev/refactor PR for update to ProtoDUNEBSMWindow TAMaker

[CiaranH1997]

Description

If full description and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.
Addresses issue #

Edits the ProtoDUNEBSMWindow TAMaker code only. Updates the XGBoost model for PD-HD triggering and adds a new model for PD-VD triggering. The TAMaker now only uses the XGBoost model for the collection plane TPs. For the induction planes it defaults to the sum of charge threshold in a window, just like ADCSW TAMaker. There are therefore now separate ADC thresholds for collection and induction planes. The collection plane thresholds are fixed values based on XGBoost model training. (200k for both models) and the induction plane ADC threshold is user configurable.

Please also include instructions for how a reviewer can test your changes.

I have run this algorithm in the replay app and had steady performance. I also ran dunedaq_integtest_bundle.sh and did not come across any issues. The build is successful.

Type of change

• Documentation (non-breaking change that adds or improves the documentation)
• New feature or enhancement (non-breaking change which adds functionality)
• Optimization (non-breaking change that improves code/performance)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (whatever its nature)

Testing checklist

• Unit tests pass (e.g. dbt-build --unittest)
• Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
• Full set of integration tests pass (dunedaq_integtest_bundle.sh)
• Python tests pass if applicable (e.g. python -m pytest)
• Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

• Code is commented where needed, particularly in hard-to-understand areas
• Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
• If applicable, new tests have been added or an issue has been opened to tackle that in the future.
  (Indicate issue here: # (issue))

[MRiganSUSX]

Thanks @CiaranH1997,
Several changes are suggested.

[CiaranH1997]

Made all changes requested and tested TAMaker again in replay mode. Stable trigger rate at 1Hz with BDE only upstream files from PD-VD.

[MRiganSUSX]

Thanks for the updates @CiaranH1997.

I have few last suggestions below. Please also see a comment on one of the previous suggestions.

After these are addressed I'd go over testing again and we should be ready to proceed.