libdatadog update to e15985f3#3944
Conversation
|
bbf5aea to
5c82d3b
Compare
61593df to
6c9ce4c
Compare
6cbfc00 to
799e351
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-06-12 02:12:19 Comparing candidate commit 63825e4 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 191 metrics, 0 unstable metrics.
|
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/118037424 Full CI result: ❌ 15 job(s) failed
799e351 to
ad1c70c
Compare
ea81580 to
63825e4
Compare
Summary
Automated update of the libdatadog submodule to the latest HEAD.
382a08732c4f0061c55f890830b5206afc3e929fe15985f3bbcf25c29a29e4527c266b1b10942c0aFull CI result: ❌ 15 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/118037424
libdatadog Integration Report
libdatadog SHA: e15985f3bbcf25c29a29e4527c266b1b10942c0a
Analysis date: 2026-06-11
Overall status
Build & test summary
15 jobs were reported as failed across the tracer and package sub-pipelines. They fall into three groups:
Rust compilation failures (12 jobs) — every
compile tracing extension asanjob (8.0–8.5, amd64 + arm64) and thecompile extension: debug-zts-asan: [7.4, arm64]job failed with the same compile error in thedatadog-phpcrate (components-rs/bytes.rs). This is a genuine libdatadog API change and is fixed below.aggregate tested versions(1 job) — this aggregation step is downstream of the compile jobs; it failed only because its inputs (the compile jobs) failed. It will recover once compilation is fixed. No code change needed.windows test_c: [7.2]and[7.3](2 jobs) — both failed withjob_execution_timeoutafter exactly 3600 s (the 1-hour job limit), not with a build/compile error. This is CI infrastructure slowness, unrelated to the libdatadog API. Treated as flaky/infra (see below).After the fix, the
datadog-phpcrate (the only crate in our tree that failed) should compile. rustc reports all errors in a crate before aborting and reported exactly 4, all inbytes.rs, so no other call sites in our code are affected.Non-trivial changes made
components-rs/bytes.rs—VecMap::remove→VecMap::remove_slowlibdatadog commit
74284cac7 refactor(span)!: use VecMap for meta, metrics and meta_struct for v04 spans (#2043)changed the backing type ofSpanBytes::meta,metricsandmeta_structfrom a hash map to the newVecMap(libdd-trace-utils/src/span/vec_map.rs).VecMapdoes not expose aremovemethod. Removal on a vector-backed map is intentionally a linearVec::retainoperation, so the API names itremove_slowto make the cost explicit:The signature (
&Qborrowed key) and semantics (remove all entries matching the key) match the oldremove(&key)usage exactly, so this is a pure rename — the compiler itself suggestedremove_slow. Updated the 4 call sites:ddog_del_span_meta_zstr:ptr.meta.remove(...)→ptr.meta.remove_slow(...)ddog_del_span_meta_str:ptr.meta.remove(...)→ptr.meta.remove_slow(...)ddog_del_span_metrics_zstr:ptr.metrics.remove(...)→ptr.metrics.remove_slow(...)ddog_del_span_metrics_str:ptr.metrics.remove(...)→ptr.metrics.remove_slow(...)The other
VecMapmethods our code uses (insert,get,contains_key) are unchanged and still present.Identified libdatadog issues
None identified. The compile failure was an expected breaking API change (
#2043), correctly flagged with a!in its conventional-commit title, and adapted with a direct equivalent.Flaky / ignored failures
windows test_c: [7.2],windows test_c: [7.3]— both ended injob_execution_timeoutat the 3600 s job limit rather than a script/compile error. This is the Windows test runner being slow, not a libdatadog API problem. Ignored as infra flakiness.aggregate tested versions— failed only as a downstream consequence of the failed compile jobs; no independent issue. Expected to pass once the compile jobs are green./cc @bwoebi