Make the SpanStack happier with cloning operations#3976
Open
bwoebi wants to merge 1 commit into
Open
Conversation
|
morrisonlevi
approved these changes
Jun 11, 2026
morrisonlevi
left a comment
morrisonlevi
left a comment
Collaborator
There was a problem hiding this comment.
Okay this looks like it might actually be the crash customers are hitting, rather than just "random" technical issues that the AI has been finding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More stuff to make sure we don't leave invalid state behind with random operations (like if a span/stack is stored in some property of a class being deeply cloned or whatever).