Skip to content

minimal secret handling policy#5

Open
SamPenrose wants to merge 3 commits into
DevProgress:masterfrom
SamPenrose:gitignore
Open

minimal secret handling policy#5
SamPenrose wants to merge 3 commits into
DevProgress:masterfrom
SamPenrose:gitignore

Conversation

@SamPenrose

Copy link
Copy Markdown

Per Slack discussion, just to kick things off. Edit mercilessly.

@review-ninja

Copy link
Copy Markdown

ReviewNinja

@decause

decause commented Aug 17, 2016

Copy link
Copy Markdown
Member

👍 from @decause, perhaps a quick 👍 from @dxa4481 or other security folks?

@dxa4481

dxa4481 commented Aug 17, 2016

Copy link
Copy Markdown

Looks good to me, if the key/data is more sensitive then there are some best practices provided by OWASP we can follow:

https://www.owasp.org/index.php/Cryptographic_Storage_Cheat_Sheet#Rule_-_Ensure_that_any_secret_key_is_protected_from_unauthorized_access

jaypinho and others added 2 commits August 17, 2016 16:50
Just a couple small OCD changes. :)
Update CONTRIBUTING.md
@decause

decause commented Aug 22, 2016

Copy link
Copy Markdown
Member

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants