refactor: Exported CSV and JSON files now list time entries in chronological order#126
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
mainbranch of tmpo.Description
This pull request updates the export functionality to ensure that exported time entries are written in chronological order (oldest first) for both CSV and JSON exports. The changes also update the corresponding tests to verify this new ordering.
Export order improvements:
ToCSVininternal/export/csv.goandToJsonininternal/export/json.goto iterate over entries in chronological order usingslices.Backward, ensuring exported data is ordered from oldest to newest. [1] [2] [3] [4]Test updates:
internal/export/export_test.goto assert that exported entries are in chronological order for both CSV and JSON exports, updating expected values accordingly. [1] [2]