Skip to content

Add additional allowed prefixes for booleans#149

Open
nusbaume wants to merge 2 commits into
ESCOMP:mainfrom
nusbaume:boolean_rule_update
Open

Add additional allowed prefixes for booleans#149
nusbaume wants to merge 2 commits into
ESCOMP:mainfrom
nusbaume:boolean_rule_update

Conversation

@nusbaume

Copy link
Copy Markdown
Collaborator

Description

This PR updates the set of allowed prefixes for booleans (e.g. variables that are of type logical in Fortran) to include do and is along with flag_for. For example, with these rule changes the following three (made up) standard names would be allowed:

flag_for_deep_convection
do_deep_convective_transport
is_convective_cloud

whereas with the current rule set all three would need to start with flag_for:

flag_for_deep_convection
flag_for_deep_convective_transport
flag_for_convective_cloud

which may not be as clear.

Issues

Addresses the "boolean indicator" discussion found in issue #101

@nusbaume nusbaume self-assigned this Jun 11, 2026
@nusbaume nusbaume added the documentation Improvements or additions to documentation label Jun 11, 2026

@climbfuji climbfuji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the idea that we can use either of? Are they / should they be considered equivalent? Otherwise, we need to come up with rules when to use do_, is_, flag_for_ (not a bad thing to have imo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants