add function for violin plot nr of obs vs err#61
Open
rogerkuou wants to merge 1 commit into
Open
Conversation
| The three inputs are expected to be xarray DataArrays with dimensions (time, lat, lon). | ||
| They should share the same spatial and temporal coordinates. | ||
|
|
||
| Parameters |
Member
There was a problem hiding this comment.
We are using Args and Return for docstring style in most of the source codes.
| axes = [axes] | ||
|
|
||
| for i, ax in enumerate(axes): | ||
| ax.set_title(f"Month = {i}") |
Member
There was a problem hiding this comment.
Please use actual time info for title as: err_baseline.time.dt.strftime('%Y-%m-%d').values[t]
| ax.set_title(f"Month = {i}") | ||
|
|
||
| # Get unique number of observations for this month, ignoring NaNs and zeros | ||
| n_obs_unique = np.unique(nobs.isel(time=i).values.flatten()) |
Member
There was a problem hiding this comment.
Suggested change
| n_obs_unique = np.unique(nobs.isel(time=i).values.flatten()) | |
| n_obs_unique = np.unique(nobs.isel(time=i).values) |
|
|
||
| # Get unique number of observations for this month, ignoring NaNs and zeros | ||
| n_obs_unique = np.unique(nobs.isel(time=i).values.flatten()) | ||
| n_obs_unique = n_obs_unique[~np.isnan(n_obs_unique)] |
Member
There was a problem hiding this comment.
Suggested change
| n_obs_unique = n_obs_unique[~np.isnan(n_obs_unique)] | |
| n_obs_unique = n_obs_unique[(~np.isnan(n_obs_unique)) & (n_obs_unique > 0)] |
| n_obs_unique = np.unique(nobs.isel(time=i).values.flatten()) | ||
| n_obs_unique = n_obs_unique[~np.isnan(n_obs_unique)] | ||
| n_obs_unique = n_obs_unique.astype(int) | ||
| n_obs_unique = n_obs_unique[n_obs_unique > 0] |
Member
There was a problem hiding this comment.
Suggested change
| n_obs_unique = n_obs_unique[n_obs_unique > 0] |
| err_by_n_obs_baseline = [] | ||
| err_by_n_obs_predictions = [] | ||
|
|
||
| for n_obs in n_obs_unique: |
Member
There was a problem hiding this comment.
n_obs is the input argument of the function. Please choose another variable name in the loop.
| h["cmaxes"].set_alpha(0.2) | ||
|
|
||
| ax.set_xlabel("Number of Daily Observations") | ||
| ax.set_ylabel("Log Absolute Error (K)") |
Member
There was a problem hiding this comment.
Suggested change
| ax.set_ylabel("Log Absolute Error (K)") | |
| ax.set_ylabel("Symmetric log-scaled Absolute Error (K)") |
| loc="upper right", | ||
| ) | ||
|
|
||
| plt.tight_layout() |
Member
There was a problem hiding this comment.
Suggested change
| plt.tight_layout() | |
| plt.tight_layout() |
| h["cmaxes"].set_linewidth(0.35) | ||
| h["cmaxes"].set_alpha(0.2) | ||
|
|
||
| ax.set_xlabel("Number of Daily Observations") |
Member
There was a problem hiding this comment.
Suggested change
| ax.set_xlabel("Number of Daily Observations") | |
| ax.set_xlabel("Number of Observations") |
Member
There was a problem hiding this comment.
Does this function work for hourly data too?
SarahAlidoost
approved these changes
Jun 26, 2026
SarahAlidoost
left a comment
SarahAlidoost
left a comment
Member
There was a problem hiding this comment.
@rogerkuou Thanks! just minor comments, after addressing them, this PR can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function plotting violin plot. Example as following