Skip to content

schemas: add offer_id to invoice_creation notification#9208

Merged
daywalker90 merged 1 commit into
ElementsProject:masterfrom
daywalker90:fix-notifications-docs
Jun 10, 2026
Merged

schemas: add offer_id to invoice_creation notification#9208
daywalker90 merged 1 commit into
ElementsProject:masterfrom
daywalker90:fix-notifications-docs

Conversation

@daywalker90

Copy link
Copy Markdown
Collaborator

Also partially reverts f960996 which was not properly rebased

PR #8981 was not properly build upon master where notifications were already derived from schemas.

Also partially reverts f960996 which was not properly rebased

Changelog-None
@daywalker90 daywalker90 requested a review from cdecker as a code owner June 10, 2026 13:33
@daywalker90 daywalker90 added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jun 10, 2026
@cdecker

cdecker commented Jun 10, 2026

Copy link
Copy Markdown
Member

Very good, just for my own understanding, why the big documentation change?

@daywalker90

Copy link
Copy Markdown
Collaborator Author

Best to describe it in a timeline:

@cdecker

cdecker commented Jun 10, 2026

Copy link
Copy Markdown
Member

Thank you for the explanation, makes sense 👍

@daywalker90 daywalker90 merged commit 46b039d into ElementsProject:master Jun 10, 2026
137 of 144 checks passed
@daywalker90 daywalker90 deleted the fix-notifications-docs branch June 10, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants