Fix build-stack manifest tag on PRs#48
Merged
Merged
Conversation
The build-stack job assembled the multi-image stack manifest from a
`${GITHUB_SHA::8}` tag that the build-and-push job never pushes, so it
failed on every PR (e.g. the develop→main promotion). Use a tag that is
actually published: `pr-<number>` on pull_request events (matches
metadata-action's type=ref,event=pr), `latest` on main, the branch name
on other branch pushes, and a `sha-<short>` fallback that matches the
type=sha tag.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #46. The
build-stackjob failed on the develop→main PR:Cause:
build-stackassembled the-stackmulti-image manifest from a${GITHUB_SHA::8}tag, butbuild-and-pushnever publishes that tag. On PRs the per-image manifests are pushed aspr-<number>(andsha-<short>), soimagetools createcouldn't find them.Fix: compute the stack tag to match what's actually published —
pr-<number>onpull_request,latestonmain, branch name on other branch pushes,sha-<short>fallback.This + #46 make the prod image pipeline green on PRs to main.
🤖 Generated with Claude Code