Insecure-connection (HTTP) warning: clean top strip instead of floating overlay#58
Merged
Conversation
…t a floating overlay
The HTTP warning was a fixed corner badge (`fixed top-4 right-4`) that floated
over the UI and constantly overlapped page content. Replace it with a single,
slim, dismissible warning strip in a standard location.
- New `InsecureConnectionBanner` (replaces the floating `TlsStatusIndicator` and
the unused `TlsSecurityBanner`): a full-width strip shown ONLY over HTTP,
dismissible for the session. Two placements:
- in-app: in-flow at the very top of the shell, so it reserves its own space
and pushes the app down instead of overlapping it;
- auth pages (no app chrome): a pinned top strip, portaled to <body> so a
transformed ancestor can't offset it.
- Layout shell is now a flex column (h-screen) with the banner as the first row
and the app filling the rest; app page roots use h-full instead of h-screen so
they shrink to the banner. With no banner (HTTPS) this is identical to before.
Verified (over HTTP): banner at top:0, slim (33px), app starts exactly at its
bottom (no overlap), no page scroll introduced, dismiss reclaims the space.
New tests/diagnostics/insecure-connection-banner.spec.ts asserts all of this;
THE GATE 5/5; web typecheck clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🧪 Comprehensive Test Suite
Full-stack smoke gate runs in the CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The "Insecure Connection (HTTP)" warning was a fixed corner badge (
fixed top-4 right-4 z-50) that floated over the UI and constantly overlapped page content. Replaced it with a single, slim, dismissible warning strip in a standard location.Approach (chosen with you: slim banner under the header, only when insecure)
InsecureConnectionBanner(replaces the floatingTlsStatusIndicatorand the unusedTlsSecurityBanner): a full-width strip shown only over HTTP, dismissible for the session. Two placements via one component:<body>so a transformed ancestor can't offset it.h-screen) with the banner as the first row and the app filling the rest; app page roots useh-fullinstead ofh-screenso they shrink to make room. With no banner (HTTPS) the layout is identical to before.Why the shell change
<body>carries a transform and every app page wash-screen(100vh), so naive padding/fixedapproaches either scrolled the page (breakingfixed) or hid the strip. An in-flow strip in a flex-column shell is immune to both.Verification (over HTTP)
top:0, slim (33px), app starts exactly at the banner's bottom (no overlap), no page scroll introduced, dismiss reclaims the space.tests/diagnostics/insecure-connection-banner.spec.tsasserts placement + no-overlap + dismiss (auth + in-app).🤖 Generated with Claude Code