Skip to content

[Enhancement] 无论何时都显示关闭愚人节模式的按钮#6105

Open
ToobLac wants to merge 2 commits into
HMCL-dev:mainfrom
ToobLac:fool
Open

[Enhancement] 无论何时都显示关闭愚人节模式的按钮#6105
ToobLac wants to merge 2 commits into
HMCL-dev:mainfrom
ToobLac:fool

Conversation

@ToobLac

@ToobLac ToobLac commented May 16, 2026

Copy link
Copy Markdown
Contributor

Closes #5982

ToobLac added 2 commits May 16, 2026 16:27
# Conflicts:
#	HMCL/src/main/java/org/jackhuang/hmcl/util/AprilFools.java
@Minecraft269

Copy link
Copy Markdown

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the April Fools settings logic by removing the conditional check AprilFools.isShowAprilFoolsSettings(). As a result, the toggle button to disable April Fools is now always visible in the settings page, and the unused isShowAprilFoolsSettings method and SHOW_APRIL_FOOLS_SETTINGS field have been removed from the AprilFools utility class. There are no review comments to address, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Minecraft269

Copy link
Copy Markdown

CC @Glavo gemini非常满意

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 无论何时都显示关闭愚人节模式的按钮

2 participants