ENH: GDCM skip find_package when *_LIBRARIES pre-set#6502
Draft
blowekamp wants to merge 1 commit into
Draft
Conversation
Guard GDCM system-library find_package with if(NOT <pkg>_LIBRARIES) so ITK module interface targets directly can be set directly. Set EXPAT_LIBRARIES/ZLIB_LIBRARIES/OPENJPEG_LIBRARIES to ITK::ITKExpatModule, ITK::ITKZLIBModule, ITK::ITKOpenJPEGModule, and GDCM_JPEGTURBO_LIBRARIES to ITK::ITKJPEGModule, bypassing GDCM's internal bundled copies.
github-actions
Bot
added
type:Infrastructure
Member
Author
|
Updating GDCM before rebasing these changes: #6520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ITK module interface targets for GDCM system libraries.
Replace the
EXPAT_INCLUDE_DIR/EXPAT_LIBRARY(singular) hint variableswith
EXPAT_LIBRARIES/ZLIB_LIBRARIESpre-set toITK::ITKExpatModuleand
ITK::ITKZLIBModule. Guard eachfind_packagecall in the GDCMsource with
if(NOT <pkg>_LIBRARIES)so a parent project that pre-setsthe plural
_LIBRARIESvariable skips the find entirely — the samepattern used in the ITK DCMTK third-party module.
AI assistance