COMP: Build examples in CI; drop spurious itk_module_examples() from IOMeshMZ3#6523
Merged
hjmjohnson merged 2 commits intoJun 26, 2026
Merged
Conversation
Build the examples during the CI configure so that modules which call itk_module_examples() without shipping an examples/ directory fail at configure time, instead of the breakage only surfacing when a developer enables examples locally.
IOMeshMZ3 called itk_module_examples(), which does add_subdirectory(examples), but ships no examples/ directory, so the configure failed once BUILD_EXAMPLES was enabled. Remove the call. Also drop the equivalent examples-omission comment from AnisotropicDiffusionLBR.
Contributor
|
| Filename | Overview |
|---|---|
| Modules/IO/IOMeshMZ3/CMakeLists.txt | Removes the examples subdirectory hook from a module that does not ship an examples/ directory. |
| pyproject.toml | Adds BUILD_EXAMPLES=ON to the CI configure task so example configuration and build issues are covered. |
| Modules/Filtering/AnisotropicDiffusionLBR/CMakeLists.txt | Removes only a comment about the already-omitted examples hook. |
Reviews (1): Last reviewed commit: "COMP: Drop itk_module_examples() from IO..." | Re-trigger Greptile
dzenanz
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
BUILD_EXAMPLESin theconfigure-cipixi task and fix the one module that broke under it:IOMeshMZ3calleditk_module_examples()(which doesadd_subdirectory(examples)) but ships noexamples/directory, failing the configure.Details
IOMeshMZ3/CMakeLists.txt— dropped the spuriousitk_module_examples()call (the module has noexamples/dir). Mirrors the existing convention inAnisotropicDiffusionLBR, which already omits the call.pyproject.toml— added-DBUILD_EXAMPLES:BOOL=ONtoconfigure-ci, so this class of breakage (a module callingitk_module_examples()without anexamples/dir) is caught at configure time in CI instead of only when a developer enables examples locally.AnisotropicDiffusionLBR/CMakeLists.txt— removed a stale explanatory comment.Validated locally:
configure-ciwithBUILD_EXAMPLES=ONconfigures cleanly, full build (incl. examples) succeeds,pre-commit run --all-filesgreen.