Skip to content

COMP: Build examples in CI; drop spurious itk_module_examples() from IOMeshMZ3#6523

Merged
hjmjohnson merged 2 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:IOMeshMZ3-Examples-Bug
Jun 26, 2026
Merged

COMP: Build examples in CI; drop spurious itk_module_examples() from IOMeshMZ3#6523
hjmjohnson merged 2 commits into
InsightSoftwareConsortium:mainfrom
hjmjohnson:IOMeshMZ3-Examples-Bug

Conversation

@hjmjohnson

Copy link
Copy Markdown
Member

Enable BUILD_EXAMPLES in the configure-ci pixi task and fix the one module that broke under it: IOMeshMZ3 called itk_module_examples() (which does add_subdirectory(examples)) but ships no examples/ directory, failing the configure.

Details
  • IOMeshMZ3/CMakeLists.txt — dropped the spurious itk_module_examples() call (the module has no examples/ dir). Mirrors the existing convention in AnisotropicDiffusionLBR, which already omits the call.
  • pyproject.toml — added -DBUILD_EXAMPLES:BOOL=ON to configure-ci, so this class of breakage (a module calling itk_module_examples() without an examples/ dir) is caught at configure time in CI instead of only when a developer enables examples locally.
  • AnisotropicDiffusionLBR/CMakeLists.txt — removed a stale explanatory comment.

Validated locally: configure-ci with BUILD_EXAMPLES=ON configures cleanly, full build (incl. examples) succeeds, pre-commit run --all-files green.

Build the examples during the CI configure so that modules which call
itk_module_examples() without shipping an examples/ directory fail at
configure time, instead of the breakage only surfacing when a developer
enables examples locally.
IOMeshMZ3 called itk_module_examples(), which does
add_subdirectory(examples), but ships no examples/ directory, so the
configure failed once BUILD_EXAMPLES was enabled. Remove the call. Also
drop the equivalent examples-omission comment from AnisotropicDiffusionLBR.
@github-actions github-actions Bot added type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module labels Jun 26, 2026
@hjmjohnson hjmjohnson marked this pull request as ready for review June 26, 2026 00:44
@hjmjohnson hjmjohnson requested a review from dzenanz June 26, 2026 00:44
@greptile-apps

greptile-apps Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR turns on example builds in CI and fixes the module that failed under that setting.

  • Enables BUILD_EXAMPLES in the configure-ci CMake command.
  • Removes itk_module_examples() from IOMeshMZ3, which has no examples/ directory.
  • Removes a stale explanatory comment from AnisotropicDiffusionLBR.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
Modules/IO/IOMeshMZ3/CMakeLists.txt Removes the examples subdirectory hook from a module that does not ship an examples/ directory.
pyproject.toml Adds BUILD_EXAMPLES=ON to the CI configure task so example configuration and build issues are covered.
Modules/Filtering/AnisotropicDiffusionLBR/CMakeLists.txt Removes only a comment about the already-omitted examples hook.

Reviews (1): Last reviewed commit: "COMP: Drop itk_module_examples() from IO..." | Re-trigger Greptile

@hjmjohnson hjmjohnson merged commit cf2d8da into InsightSoftwareConsortium:main Jun 26, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module type:Compiler Compiler support or related warnings type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants