ENH: Retire FEM modules to InsightSoftwareConsortium/ITKFEM remote#6524
Draft
hjmjohnson wants to merge 1 commit into
Draft
ENH: Retire FEM modules to InsightSoftwareConsortium/ITKFEM remote#6524hjmjohnson wants to merge 1 commit into
hjmjohnson wants to merge 1 commit into
Conversation
Remove the opt-in (EXCLUDE_FROM_DEFAULT) ITKFEM (Modules/Numerics/FEM) and ITKFEMRegistration (Modules/Registration/FEM) modules from the main tree and replace them with a Modules/Remote/FEM.remote.cmake breadcrumb pointing at the extracted, full-history InsightSoftwareConsortium/ITKFEM repository. The remote is compliance-level 1 (the lowest itk_fetch_module can express; 0 is promoted to 1), emits a loud enable-time warning, and is scheduled for removal in ITK 7 (see InsightSoftwareConsortium#6511). Also remove the two FEM-based deformable registration examples and their data files, drop FEM references from the Registration module group documentation and the license attribution list, and document the retirement in the ITK 6 migration guide.
github-actions
Bot
added
the
type:Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the FEM modules (
ITKFEM,ITKFEMRegistration) from the ITK main tree, replacing them with aModules/Remote/FEM.remote.cmakebreadcrumb pointing at the new full-history remote repository InsightSoftwareConsortium/ITKFEM. Phase 1 of #6511.What this does
Modules/Numerics/FEM(ITKFEM) andModules/Registration/FEM(ITKFEMRegistration) — both opt-in (EXCLUDE_FROM_DEFAULT); no in-tree module depended on them.Modules/Remote/FEM.remote.cmake(MODULE_COMPLIANCE_LEVEL 1, pinnedGIT_TAG) with a loud enable-time warning that the module is unmaintained and slated for removal in ITK 7, asking dependents to comment on Tracking: Retire the FEM module (ITKFEM / ITKFEMRegistration) to reduce maintenance burden #6511.History preservation + verification
The remote repo was produced with
git filter-repofrom a fresh clone, retaining the complete history (1,290 commits back to the original 2001 check-in by Aljaž Noe, 137 merges) with legacyCode/-era paths normalized onto today'sModules/.../FEMlayout. Content is tree-hash identical toupstream/mainFEM.End-to-end verified locally: enabling
Module_FEMclones the remote, fires the warning, discovers both nested modules, and buildslibITKFEM+libITKFEMRegistration.