Identify the correct ledger era for local state queries#62
Open
crocodile-dentist wants to merge 1 commit into
Open
Identify the correct ledger era for local state queries#62crocodile-dentist wants to merge 1 commit into
crocodile-dentist wants to merge 1 commit into
Conversation
crocodile-dentist
force-pushed
the
mw/fix-era-query
branch
from
eac304e to
b8333d2
Compare
coot
reviewed
Jun 19, 2026
crocodile-dentist
force-pushed
the
mw/fix-era-query
branch
from
b8333d2 to
7114a29
Compare
coot
approved these changes
Jun 19, 2026
| Left err -> | ||
| pure $ SendMsgRelease do | ||
| traceWith tracer $ PastHorizon err | ||
| threadDelay 86400 |
Contributor
There was a problem hiding this comment.
This should be smaller, maybe 10-30 minutes (we won't spam the node if we do these simple queries every 10 minutes or so). Otherwise if dmq-node was started just before the epoch boundary we wait a day before it gets the data.
Contributor
Author
There was a problem hiding this comment.
I don't think that can happen. If we are 'close' to an epoch boundary then its not possible to take this branch, otherwise that would be problematic for the hfc (I think). I don't know how close is close, but it seems like a day shouldn't be extravagant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Fixes the issue of hardcoded conway era query, which would cause a crash on an era transition.
Checklist