Skip to content

Tier might be none for perpetual license#11

Merged
ildyria merged 1 commit into
mainfrom
lax
Jun 21, 2026
Merged

Tier might be none for perpetual license#11
ildyria merged 1 commit into
mainfrom
lax

Conversation

@ildyria

@ildyria ildyria commented Jun 21, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Improved system validation logic to handle additional response states more effectively, reducing unnecessary failures and enhancing compatibility with expected operational scenarios.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: caf9ba02-b9b8-473e-b291-bfea2918457d

📥 Commits

Reviewing files that changed from the base of the PR and between 1bfbdef and 97d54fa.

📒 Files selected for processing (1)
  • src/Rotation.php

📝 Walkthrough

Walkthrough

In Rotation::rotate(), the early-return validation condition is narrowed: it now exits only when value or tier are absent from the API response, removing the prior check that also rejected responses with tier === 'none'.

Changes

Tier Validation Gate

Layer / File(s) Summary
Remove 'none' tier early-exit check
src/Rotation.php
The condition at line 52 no longer treats tier === 'none' as a validation failure; only missing value or tier keys trigger an early return.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped in, erased a small gate,
No more turning away when the tier says "none" mate.
The key must be missing for failure to ring,
One line, one small change — a very light thing.
🐇✂️ Snip snip, off it goes!

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ildyria ildyria merged commit 7bb6316 into main Jun 21, 2026
17 of 18 checks passed
@ildyria ildyria deleted the lax branch June 21, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant