Update parameters for logical network creation#4276
Conversation
Fixed CLI syntax in static logical network example. Added missing space between --no-gateway and --ip-pool-start. Corrected undefined PowerShell variable $fabricResourceID in the example.
|
Learn Build status updates of commit 52567d2: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Pull request overview
Updates the multi-rack “static logical network” documentation example to ensure the provided CLI snippet is syntactically correct and the referenced variables are defined.
Changes:
- Replaced an unused/incorrect internal network variable with
$fabricResourceIDin the parameter setup. - Fixed the
az stack-hci-vm network lnet createexample so flags are correctly spaced/continuous (no broken line). - Reordered IP pool variables and normalized the “Next steps” list formatting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```azurecli | ||
| $lnetName = "mylocal-lnet-static" | ||
| $internalNetworkName = "<Layer 3InternalNetwork>" | ||
| $fabricResourceID = "<Layer 3InternalNetworkID>" |
There was a problem hiding this comment.
@ronmiab I like the change AI is recommending here; however, the ARM ID shape is not quite right in the example. Can you change it to say this instead for the $fabricResourceID example?
"/subscriptions//resourceGroups/mylocal-rg/providers/Microsoft.ManagedNetworkFabric/l3IsolationDomains/<Layer 3 Isolation Domain> /internalNetworks/"
I am unable to edit this fork. Don't seem to have permissions.
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
Bot
added
the
aq-pr-triaged
|
This pull request has been inactive for 7 days. |
|
@kerimhanif : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
prmerger-automator
Bot
added
azure-local/svc
Change sent to author
multi-rack/subsvc
labels
|
@kerimhanif : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
vary1646
left a comment
vary1646
left a comment
There was a problem hiding this comment.
Added some minor review comments.
| ```azurecli | ||
| az stack-hci-vm network lnet create --subscription $subscription --resource-group $resource_group --custom-location $customLocationID --location $location --name $lnetName --ip-allocation-method "Static" --address-prefixes $addressPrefixes --no-gateway | ||
| --ip-pool-start $ipPoolStart --ip-pool-end $ipPoolEnd --ip-pool-type "vm" --dns-servers $dnsServers --fabric-network-configuration-id $fabricResourceID --vlan $vlan | ||
| az stack-hci-vm network lnet create --subscription $subscription --resource-group $resource_group --custom-location $customLocationID --location $location --name $lnetName --ip-allocation-method "Static" --address-prefixes $addressPrefixes --no-gateway --ip-pool-start $ipPoolStart --ip-pool-end $ipPoolEnd --ip-pool-type "vm" --dns-servers $dnsServers --fabric-network-configuration-id $fabricResourceID --vlan $vlan |
There was a problem hiding this comment.
@kerimhanif thanks for making the tweak to add the space between the parameters. Apart from that, I notice in this PR fork the gateway input is given as --no-gateway whereas in public docs on what is live it is like below in the link here: https://learn.microsoft.com/en-us/azure/azure-local/multi-rack/multi-rack-create-logical-networks?view=azloc-2606
--gateway $gateway
I'd leave it as it the same way as it is on the live doc.
@ronmiab FYI
Fixed CLI syntax in static logical network example. Added missing space between --no-gateway and --ip-pool-start. Corrected undefined PowerShell variable $fabricResourceID in the example.
Changed the order in the variable list, moved $ipPoolStart to the top