refactor(web): extract pure turn-rendering helpers from ChatPane#1001
Merged
Conversation
🦋 Changeset detectedLatest commit: fd9568f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Pure-logic tests for the helpers extracted from ChatPane, focused on assistantRenderBlocks (tool-stack grouping, interrupt/media break, single tool) plus the formatting/boundary helpers. Doubles as a safety net confirming the extraction preserved behavior.
This was referenced Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A — internal refactor, no user-facing behavior change.
Problem
ChatPane.vuewas ~1550 lines, with roughly 400 lines of<script setup>helper functions mixed in with the component's reactive state, props, and emits. Many of those helpers are pure functions of a chat turn (rendering, formatting, markdown conversion) and don't need to live in the component.What changed
Extract the pure turn-rendering helpers into a new module
chatTurnRendering.ts:ChatPane.vue1550 → 1427 lines.chatTurnRendering.ts(139 lines) exports:formatTokens,formatDuration,turnBlocks,rendersToolCard,toolStackPosition,toolStackKey,renderBlockKey,assistantRenderBlocks,turnFinalText,turnToMarkdown, plus the typesToolStackPosition,ToolStackItem,AssistantRenderBlock.TurnBlockis imported from../types(single source of truth) rather than redefined.compactionDividerLabel) stay inChatPane.vue.Function bodies are relocated byte-for-byte (only
exportadded);ChatPane.vueimports them back. No behavior change. Verified withtypecheck,test(26),build, andoxlint(0 errors / 0 warnings on the changed files).This continues the big-component split from the web refactor plan (after
Sidebar → WorkspaceGroupin #998).Checklist
gen-changesetsskill, or this PR needs no changeset. (Patch on@moonshot-ai/kimi-code;@moonshot-ai/kimi-webis ignored and bundled into the CLI.)gen-docsskill, or this PR needs no doc update. (No user-facing behavior change.)