CCM-12600: Add sha256 to letters#606
Open
RossFaulds171 wants to merge 31 commits into
Open
Conversation
RossFaulds171
added
the
deploy-proxy
stevebux
previously approved these changes
Jun 11, 2026
stevebux
left a comment
stevebux
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just a couple of comments
|
stevebux
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add sha256 to get letters and get letter api endpoints, and ensure hash is stored in db as well.
Changed Letter schema to have sha256Hash defined.
Changed Open API spec to have sha256Hash defined.
Changed mapping functions to copy hash value
Changed tests to account for hashes
Added extra component and e2e tests to provide hash works
Context
Currently the Sha256 hash is not exposed anywhere, and therefore cannot be used for any purposes, such as checking for pdf file tampering etc.
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.