Fix logging of error response body in AS2SenderModule#545
Merged
Conversation
Updated log message to decode response body as UTF-8.
uhurusurfa
approved these changes
Jun 22, 2026
uhurusurfa
left a comment
Contributor
There was a problem hiding this comment.
👍 Thanks for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HTTP error response body logging in AS2SenderModule
Problem
When a partner returns a non-2xx HTTP response code, the error log message displays the raw Java byte array reference instead of the actual response body content.
Example of current broken output:
This is caused by calling
.toString()on thebyte[]returned byresp.getBody(), which in Java outputs the type prefix[Band the object hash code rather than the string content.Fix
Replace
.toString()withnew String(resp.getBody(), StandardCharsets.UTF_8)to correctly decode the response body bytes into a readable string.Changes
AS2SenderModule.java—sendMessage()method:Impact
No behavioral change — error handling and resend logic are unaffected. This only improves the content of the log message so that partner error responses are human-readable, which significantly aids in debugging failed transmissions.