Conversation
|
No API break detected ✅ |
IAlibay
approved these changes
Jun 12, 2026
IAlibay
left a comment
Member
There was a problem hiding this comment.
Just needs a news item, otherwise looks good.
Contributor
I'm also not so sure, I think both options make sense, but of course answer a different question. Is there something in the best practices paper about this? |
Member
|
I would prefer the standard deviation rather than the standard error as the main measure of uncertainty. We can discuss this more offline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the uncertainty functions on protocol results to return the unbiased estimate of the standard deviation from the sample population.
Questions
SE = std / sqrt(n)which is the uncertainty in the estimate of the average rather than the spread of the data? Where std is the unbiased estimate?n=1the uncertainty will now return Nan?Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin