Allow python 3.12 and add to workflow#83
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 6 6
Lines 301 301
=======================================
Hits 283 283
Misses 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I actually discussed this with @dilpath very recently, and basically currently numpy requires 3.12 for this year and 3.13 for next year. So I would be happy to change to requiring at least 3.12 |
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks! Agreed with @sebapersson. So the range can be 3.12 - 3.14, since 3.13 is no longer the newest Python.
| continue | ||
|
|
||
| array_file_relative = array_file.relative_to(yaml_dir, walk_up=True).as_posix() | ||
| array_file_relative = Path(os.path.relpath(array_file, yaml_dir)).as_posix() |
| files: ./coverage.xml | ||
| if: matrix.os == 'ubuntu-latest' | ||
|
No newline at end of file |
||
| if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.13' |
There was a problem hiding this comment.
The explicit 3.13 here is not so nice -- is there a way to make it dynamic somehow, e.g. to the latest python version?
There was a problem hiding this comment.
Updated to 3.x which will pull the latest python (currently 3.14.5).
| @@ -1,5 +1,6 @@ | |||
| from __future__ import annotations | |||
|
|
|||
| import os | |||
This reverts commit 3b69b72.
BSnelling
changed the title
|
Thanks both! That's a good case for 3.12, I've updated to reflect that. And I reckon I can make the case for AMICI to reflect the same. |
sebapersson
left a comment
sebapersson
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
4 participants
If there isn't a particular reason to specify
>=3.13I think>=3.11is reasonable. This would bring petab_sciml into line with libpetab and amici, which both specify>=3.11.